Date: Wed, 12 May 2021 14:10:49 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Pavel Stehule <pavel.stehule@gmail.com>
Cc: Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Stephen Frost <sfrost@snowman.net>,
	Bruce Momjian <bruce@momjian.us>, Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210512061049.dykngnivdoesquxb@nol>
References: <20210511105249.2obdq32n6tc5gyqd@nol>
 <20210512.110836.2162399537656469720.horikyota.ntt@gmail.com>
 <20210512024201.ak3ofofakn2ymhiv@nol>
 <20210512.143335.1053382893089496881.horikyota.ntt@gmail.com>
 <CAFj8pRB0isJLNBcom3czQCC3g7S6ZFc59jdPfps00r8j=dVZbg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFj8pRB0isJLNBcom3czQCC3g7S6ZFc59jdPfps00r8j=dVZbg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20210512061049.dykngnivdoesquxb%40nol>
Precedence: bulk

On Wed, May 12, 2021 at 07:49:13AM +0200, Pavel Stehule wrote:
> 
> > Ah, I missed that case.  And we are wanting to use pg_stat_statements
> > with (almost) zero-config?  How about the following behavior?
> >
> >
> Until now, the pg_stat_statements was zero-config. So the change is not
> user friendly.

Apart from configuring shared_preload_libraries, but agreed.

> The idea so pg_stat_statements requires enabled computed_query_id is not
> good. There should be dependency only on the queryid column.

I agree that requiring to change compute_query_id when you already added
pg_stat_statements in shared_preload_libraries isn't good, and the patch I sent
yesterday would fix that.