Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh1JH-0005ex-Lq for pgsql-hackers@arkaria.postgresql.org; Thu, 13 May 2021 02:42:47 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lh1JF-0005zt-Il for pgsql-hackers@arkaria.postgresql.org; Thu, 13 May 2021 02:42:45 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lh1JF-0005zB-B4 for pgsql-hackers@lists.postgresql.org; Thu, 13 May 2021 02:42:45 +0000 Received: from mail-pg1-x532.google.com ([2607:f8b0:4864:20::532]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lh1JA-0003AV-JC for pgsql-hackers@lists.postgresql.org; Thu, 13 May 2021 02:42:44 +0000 Received: by mail-pg1-x532.google.com with SMTP id m37so19938578pgb.8 for ; Wed, 12 May 2021 19:42:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=MzKaGUifoNHceVtywTa0gbAyrrMuHZk0hFkave0Oi6I=; b=As2IgZVA5L5/qQxBZWOPpyc7scTnDFu9vlnIhumFhSm2hR/UtFtKKQvA/vTLWgE01L RMVEa1WS7pZHAGclmb/fFWAsbHdAEQgZ/sRH15dfJSAdfXvt9VoApRiH3hsb0pbaOW+2 hfBZ86aFpoQ88wRZlOvi5ra3KI0ZB+oSeEdvKm8mhSbdbfxiMHBJ+IX/GpLpQNGKkohe v6/gsXkh2ECxLrueXMnTrXmlJ/HCBxnVheQYsf05XOI+u+aP7mZTsulr/eEIbg8MzAUV H3vn8tlsyHwtWYjD/qOXSKA7UfqfqC1n6tdtrFEenVrTgkYmHaPPHfb3bbeKtXt77zPU DoFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=MzKaGUifoNHceVtywTa0gbAyrrMuHZk0hFkave0Oi6I=; b=mvMmPdnA8WP7cbiX0kUDhQJM1y/qW6KKWh6VvVljGCvTy/5hP8AAmgflVkwxOI7kPS YYt+tE9voq0YWRX/FOMvjqlQTdnfUjeIftw0pvoV7QAsaY5/3TSSY6zoBukv7lWenQ57 TvUP/k1SAQAHFH+UV+V5VHicN4+Il1FVJWF3XpesxhH+l6ne2rslE3N6wn2VsZrD/zNX OVKbHYSqoa/3ja+pGTwM9uTO2yRkV2mASsXH+0d5uBZgpb5V8BohBtu6Go6SgQyeZ94B d9FeXmZR4oIbeswFjc+WOXXDXWP+o2evhD9YSZ3jWfsf7pQ/ldZ82phQqw4+HRhbsZMP mepg== X-Gm-Message-State: AOAM531VP4QooGflLZxeM1F9I2Sl3SY7b7qdjCH+FMQPq4TIIPYzrTCj 9HATK6tyW8usOT2vmqws5e8= X-Google-Smtp-Source: ABdhPJyMjsCW4w569RSD2eK9MYHflqmnZrNKx2Uy2pttlncjlM4VwqNEYYZMxs9MP657DCgunreEvA== X-Received: by 2002:a62:5209:0:b029:278:648f:99b6 with SMTP id g9-20020a6252090000b0290278648f99b6mr38236201pfb.9.1620873759453; Wed, 12 May 2021 19:42:39 -0700 (PDT) Received: from nol (2001-b011-0008-3a8c-638b-a3db-2ad1-c7d1.dynamic-ip6.hinet.net. [2001:b011:8:3a8c:638b:a3db:2ad1:c7d1]) by smtp.gmail.com with ESMTPSA id e13sm839299pfi.199.2021.05.12.19.42.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 19:42:39 -0700 (PDT) Date: Thu, 13 May 2021 10:43:03 +0800 From: Julien Rouhaud To: Kyotaro Horiguchi Cc: magnus@hagander.net, masao.fujii@oss.nttdata.com, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, alvherre@alvh.no-ip.org, sfrost@snowman.net, bruce@momjian.us, myon@debian.org, peter.eisentraut@enterprisedb.com, pgsql-hackers@lists.postgresql.org Subject: Re: compute_query_id and pg_stat_statements Message-ID: <20210513024303.e5ddm54f6hc6pdff@nol> References: <20210513.095943.2029736808766317326.horikyota.ntt@gmail.com> <20210513.105152.1649475530581175603.horikyota.ntt@gmail.com> <20210513020245.wjswdvzmasfxrbqs@nol> <20210513.112629.407758843298621458.horikyota.ntt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210513.112629.407758843298621458.horikyota.ntt@gmail.com> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Thu, May 13, 2021 at 11:26:29AM +0900, Kyotaro Horiguchi wrote: > > I believe any "real" > alternative query-id provider is supposed to be hooked "before" > pg_stat_statements. (It is a kind of magic to control the order of > plugins, though.. Indeed, you have to configure shared_preload_libraries depending on whether each module calls the previous post_parse_analyze_hook before or after its own processing, and that's the main reason why I think a dedicated entry point would be better.