Date: Thu, 13 May 2021 13:33:27 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	Bruce Momjian <bruce@momjian.us>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210513173327.GD20766@tamriel.snowman.net>
References: <20210513005236.aj7n6b76yjsxythc@nol>
 <20210513011325.GA11075@momjian.us>
 <20210513015700.fp33q5rfvwl2ahfx@nol>
 <20210513030652.GB11075@momjian.us>
 <20210513031613.j47baglf6xl3mgbs@nol>
 <20210513033332.GF11075@momjian.us>
 <20210513040342.fouh7ryglrfgxglu@nol>
 <e3d3e3e5-0b33-5165-9121-6e770830e609@oss.nttdata.com>
 <d7a5dd14-27a9-931e-3901-02319cef669b@dunslane.net>
 <1576471.1620926236@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="4uYDHwxeWVfU+JOj"
Content-Disposition: inline
In-Reply-To: <1576471.1620926236@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210513173327.GD20766%40tamriel.snowman.net>
Precedence: bulk


--4uYDHwxeWVfU+JOj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Tom Lane (tgl@sss.pgh.pa.us) wrote:
> Andrew Dunstan <andrew@dunslane.net> writes:
> > The only thing that bugs me is that we're pretty damn late in the
> > process to be engaging in this amount of design.
>=20
> Indeed.  I feel that this feature was forced in before it was really
> ready.

I'm coming around to have a similar feeling.  While having an
alternative query ID might be useful, I have a hard time seeing it as
likely to be a hugely popular feature that is worth a lot of users
complaining (as we've seen already, multiple times, before even getting
to beta...) that things aren't working anymore.  That we can't figure
out which libraries to load automatically based on what extensions have
been installed and therefore make everyone have to change
shared_preload_libraries isn't a good thing and requiring additional
configuration for extremely common extensions like pg_stat_statements is
making it worse.

Thanks,

Stephen

--4uYDHwxeWVfU+JOj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJgnWLnAAoJEO1sijiDR2RVrS0P/RECyOBu8II+LIcjwAbLf6wp
HGZTo9ef4zuukkiEOCG8hb0zroftpMunXpbloAaFIhMDfqkie+YU9gwfVUl8vvfX
FttCeIOXotz7+IT6PMVRYb5Zj5+XOAu4c6bMa4sp36oQfWiSvxcXAHUr/HS+XuGa
e3eTz7+jf+/Rg40yOWT7EQiPccKuDLPjeLJsCfFbG8g772BEkASRGddvyzl6PBcG
/sM7F2gG3Hg9lehrY/6sIljLq/PnnbBGKx+4eNSdQuZC5fbClC7C4uyx5EMOcn6c
5y3NXgatgRuOwViZneWBiaWx2wCRdLCBU8z/n9RBHNRM9bZR2P0PhR3Hv0k2X68I
8LS8Nlu2uiiDk89eWE47jnu70hsH7+YRmORNvJn8npFTP1KzfuKecm/tYT0FobLR
9W7z61siKp9+kQ8kjF4c4cu7gltFqmpm5SDThQ1Sd5QjCyjHAcXLdEFdOuKUyhxN
Z1+02LZv/IgKwiIOZRwL0ZaY95fB+G9wPObtMgPFwRfSJSVP7dEaxIj0Qbsf3qhh
KyXk04R3yVMhfc//zCwb7sQjV0kWxdGakjcJdGI4dyNhgT+f7d1UVojAqL9lJm1j
Ij4CnAUoRjnlN4ME36oF32fdz/bk2Pre2lVbrPDoC1VuuVqBoKzJLC298ZOoe8Jp
kPyiCN+w9yg1VJ3xS0eo
=EWVk
-----END PGP SIGNATURE-----

--4uYDHwxeWVfU+JOj--