Date: Thu, 13 May 2021 13:51:07 -0400
From: Stephen Frost <sfrost@snowman.net>
To: Bruce Momjian <bruce@momjian.us>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Julien Rouhaud <rjuju123@gmail.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210513175107.GF20766@tamriel.snowman.net>
References: <20210513015700.fp33q5rfvwl2ahfx@nol>
 <20210513030652.GB11075@momjian.us>
 <20210513031613.j47baglf6xl3mgbs@nol>
 <20210513033332.GF11075@momjian.us>
 <20210513040342.fouh7ryglrfgxglu@nol>
 <e3d3e3e5-0b33-5165-9121-6e770830e609@oss.nttdata.com>
 <d7a5dd14-27a9-931e-3901-02319cef669b@dunslane.net>
 <1576471.1620926236@sss.pgh.pa.us>
 <20210513173327.GD20766@tamriel.snowman.net>
 <20210513174115.GN11075@momjian.us>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="Ml+SCT/uiqve0Bsz"
Content-Disposition: inline
In-Reply-To: <20210513174115.GN11075@momjian.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210513175107.GF20766%40tamriel.snowman.net>
Precedence: bulk


--Ml+SCT/uiqve0Bsz
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Greetings,

* Bruce Momjian (bruce@momjian.us) wrote:
> On Thu, May 13, 2021 at 01:33:27PM -0400, Stephen Frost wrote:
> > I'm coming around to have a similar feeling.  While having an
> > alternative query ID might be useful, I have a hard time seeing it as
> > likely to be a hugely popular feature that is worth a lot of users
> > complaining (as we've seen already, multiple times, before even getting
> > to beta...) that things aren't working anymore.  That we can't figure
> > out which libraries to load automatically based on what extensions have
> > been installed and therefore make everyone have to change
> > shared_preload_libraries isn't a good thing and requiring additional
> > configuration for extremely common extensions like pg_stat_statements is
> > making it worse.
>=20
> Would someone please explain what is wrong with what is in the tree
> now, except that it needs additional warnings about misconfiguration?=20
> Requiring two postgresql.conf changes instead of one doesn't seem like a
> valid complaint to me, especially if the warnings are in place and the
> release notes mention it.

Will you be updating pg_upgrade to detect and throw a warning during
check in the event that it discovers a broken config?

If not, then I don't think you're correct in arguing that this need for
additional configuration isn't a valid complaint.

Thanks,

Stephen

--Ml+SCT/uiqve0Bsz
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBCgAGBQJgnWcLAAoJEO1sijiDR2RVv/kQAK8IlxKDEMstjq3M6IuHASFW
YT+NUOMYjtQKqMjO+nfhPU6APDdN4knHLjNoKp2DMlViuki9zAATA1DTUJ/g4vR7
MWYQn+LIZ3TzQQeVhKQoYH/6amTZI3nibW6IgjYW6YxeU4UL9ZVqGxkTjLVN/VQC
0evc/QWEXypFjxlaxfqRVg9xvPxcYQw/0XvkkOQ3eobEhcCggz7oKW076BnyAOPm
qW3aX9mCUhI/ywcGAnEnx10KFevOjM7Kn/mSNs1LvtX8bZAyUY4SHxhpXLDVjpJk
MSdR2lp/jMyckUXe/fhHI211OhO9s2OLaMPfSrSytisBuCXK0WuTJQx2AroaFkIU
MT8iP+WSApQnDYm/D21LJ32HVHBPvmq2P0cxsCaLRlwqOo8Zc4x8ioYZhg7QGpKN
JPg5BZ7wwo6T8Kh25HXVCBH8b+S8qP2sSwZcee3DxXIV3G+EtM3iDJyOKOmjEix6
qbV3D1FUPQca2yenWvEo+1YbUGov7ta3nFsM2Bgdq2IwH7wE0SDULpGAb/OzKhMr
+krcyX+37Y6uEKeGcwjac86lv18U25XmE6Y3fmihY66FWOCS/ELLyby4PE02iEVa
icK+qLhwkRgdBLQWA4l2sxjRepiWBWEYpPixPocMGCuSbwTX+CTs5y3BrnB4UN/2
BTumep/K5nV9pfgAZab3
=WERv
-----END PGP SIGNATURE-----

--Ml+SCT/uiqve0Bsz--