Date: Sat, 15 May 2021 18:33:58 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	pgsql-hackers@postgresql.org
Subject: Re: PG 14 release notes, first draft
Message-ID: <20210515233358.GA373@telsasoft.com>
References: <20210515183015.GN22344@momjian.us>
 <20210515231228.GA3353@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210515231228.GA3353@alvherre.pgsql>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210515233358.GA373%40telsasoft.com>
Precedence: bulk

On Sat, May 15, 2021 at 07:12:28PM -0400, Alvaro Herrera wrote:
> On 2021-May-15, Bruce Momjian wrote:
> > On Fri, May 14, 2021 at 04:01:32PM -0400, Bruce Momjian wrote:
> > > On Fri, May 14, 2021 at 03:39:39PM -0400, Tom Lane wrote:
> > > > Bruce Momjian <bruce@momjian.us> writes:
> > > > > On Thu, May 13, 2021 at 09:01:41PM -0500, Justin Pryzby wrote:
> > > > >> New SQL-accessible functionality should be included:
> > > > >>> 8c15a29745 Allow ALTER TYPE to update an existing type's typsubscript value.
> > > > 
> > > > > OK, text is:
> > > > 
> > > > > 	<listitem>
> > > > > 	<!--
> > > > > 	Author: Tom Lane <tgl@sss.pgh.pa.us>
> > > > > 	2020-12-11 [8c15a2974] Allow ALTER TYPE to update an existing type's typsubscri
> > > > > 	-->
> > > > 	
> > > > > 	<para>
> > > > > 	Allow ALTER TYPE to specify or remove a SUBSCRIPT handler
> > > > > 	(Tom Lane)
> > > > > 	</para>
> > > > > 	</listitem>
> > > > 
> > > > I don't understand why we'd bother to list that as a separate bullet item.
> > > > It's an expected part of the custom-subscript capability, I'd think.
> > > 
> > > I am not sure either.
> > 
> > Removed.
> 
> So now we don't have anything that mentions ALTER TYPE / SUBSCRIPT,
> because the item is about JSONB, not about subscripts.  Moreover it
> seems misplaced in the "functions" subsection -- subscripting is
> replacing what used to be function calls, but really it's more than
> that.  I think it should be in "datatypes", and I further think it
> should mention ALTER TYPE SUBSCRIPT too.
> 
> I, um, again think that the item should not be primarily about JSONB,
> but about our (IMO groundbreaking) extensible subscripting work.


Maybe it should be included, but merged with the existing item, like this.

Allow subscripting of non-array types.

This is implemented for the JSONB type, allowing to extract from and assign to
JSONB documents.
A new ALTER TYPE syntax allows to specify or remove a SUBSCRIPT handler.

Merge with the hstore item?

-- 
Justin