Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1liTgW-00044a-Bz
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 May 2021 03:12:48 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1liTgV-0008QS-AL
	for pgsql-hackers@arkaria.postgresql.org; Mon, 17 May 2021 03:12:47 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1liTgV-0008QG-2w
	for pgsql-hackers@lists.postgresql.org; Mon, 17 May 2021 03:12:47 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1liTgT-0005dt-2k
	for pgsql-hackers@lists.postgresql.org; Mon, 17 May 2021 03:12:46 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1liTgI-0003EB-HY; Sun, 16 May 2021 23:12:34 -0400
Date: Sun, 16 May 2021 23:12:34 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Julien Rouhaud <rjuju123@gmail.com>,
	Fujii Masao <masao.fujii@oss.nttdata.com>,
	Pavel Stehule <pavel.stehule@gmail.com>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Magnus Hagander <magnus@hagander.net>,
	Michael Paquier <michael@paquier.xyz>,
	Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>,
	Stephen Frost <sfrost@snowman.net>,
	Christoph Berg <myon@debian.org>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: compute_query_id and pg_stat_statements
Message-ID: <20210517031234.GD24531@momjian.us>
References: <20210515213258.GA21748@momjian.us>
 <20210515230125.GA2951@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210515230125.GA2951@alvherre.pgsql>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20210517031234.GD24531%40momjian.us>
Precedence: bulk

On Sat, May 15, 2021 at 07:01:25PM -0400, Álvaro Herrera wrote:
> On 2021-May-15, Bruce Momjian wrote:
> 
> > On Sat, May 15, 2021 at 02:21:59PM -0400, Álvaro Herrera wrote:
> 
> > > I wonder why the initial line says "query hash" instead of "query
> > > identifier".  Do we want to say "hash" everywhere?  Why didn't we name
> > > the GUC "compute_query_hash" in that case?
> > 
> > It is queryid (no underscore) in pg_stat_statements, which was a whole
> > different discussion.  ;-)
> 
> Yeah, I realize that, but I wonder if we shouldn't use the term "query
> identifier" instead of "query hash" in that paragraph.

Yes, of course, you are right --- updated text:

	<listitem>
	<!--
	Author: Bruce Momjian <bruce@momjian.us>
	2021-04-07 [4f0b0966c] Make use of in-core query id added by commit 5fd9dfa5f5
	Author: Bruce Momjian <bruce@momjian.us>
	2021-04-07 [f57a2f5e0] Add csvlog output for the new query_id value
	Author: Bruce Momjian <bruce@momjian.us>
	2021-04-20 [9660834dd] adjust query id feature to use pg_stat_activity.query_id
	Author: Bruce Momjian <bruce@momjian.us>
	2021-05-03 [f7a97b6ec] Update query_id computation
	Author: Alvaro Herrera <alvherre@alvh.no-ip.org>
	2021-05-15 [cafde58b3] Allow compute_query_id to be set to 'auto' and make it d
	-->
	
	<para>
	If server variable compute_query_id is enabled, display the query
	id in pg_stat_activity, EXPLAIN VERBOSE, csvlog, and optionally
	in log_line_prefix (Julien Rouhaud)
	</para>
	
	<para>
	A query id computed by an extension will also be displayed.
	</para>
	</listitem>

> 
> > I also added Alvaro as an author of the compute_query_id item.
> 
> I've been wondering if I should ask to stick my name in other features I
> helped get committed -- specifically the PQtrace() item and autovacuum
> for partitioned tables.  I'll go comment in the release notes thread.

Yes, done.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.