Date: Tue, 18 May 2021 11:48:10 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Peter Geoghegan <pg@bowt.ie>
Cc: Justin Pryzby <pryzby@telsasoft.com>,
	Masahiko Sawada <sawada.mshk@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Subject: Re: PG 14 release notes, first draft
Message-ID: <20210518154810.GD30270@momjian.us>
References: <20210510060308.GC6088@momjian.us>
 <CAD21AoC20kffpNLNLGKzGGjahniYJ+BwW_B0pVTQ3gK-rfgHuw@mail.gmail.com>
 <20210518140725.GA30270@momjian.us>
 <20210518144409.GL373@telsasoft.com>
 <CAH2-Wzn_sZ17x4L40JuQ8VgdW-NrNfwL19HSUDx+qnZAHf3-=Q@mail.gmail.com>
 <20210518150948.GC30270@momjian.us>
 <CAH2-WzmzXdxY0w-WCo+9Pw-FL9eWiUjFHXEHBMxjMrSopgNB9A@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAH2-WzmzXdxY0w-WCo+9Pw-FL9eWiUjFHXEHBMxjMrSopgNB9A@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210518154810.GD30270%40momjian.us>
Precedence: bulk

On Tue, May 18, 2021 at 08:34:55AM -0700, Peter Geoghegan wrote:
> In my opinion this should be interpreted as already handled by the
> backpatch to 13.3, and so not necessary to handle again now -- despite
> the GUC thing. It's possible that no users set the GUC at all, because
> it wasn't particularly well thought out. This entire situation is
> probably unprecedented (we just don't deprecate reloptions very
> often), so I defer to your judgement, Bruce.

I am thiking the vacuum_cleanup_index_scale_factor existance in a PG 14
postgresql.conf will throw an error, unlike 13.x, so I do think we need
to mention this so people will know to remove it from their
postgresql.conf before upgrades, right?  I don't think the PG 13.3
release note mention really makes it clear it has to be removed.  In a
dump/restore, so we retain the reloption
vacuum_cleanup_index_scale_factor and just ignore it, or drop it on
restore?  I am hoping it is the later.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.