Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ljqMh-0008MH-PC
	for pgsql-hackers@arkaria.postgresql.org; Thu, 20 May 2021 21:37:59 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1ljqMg-00070F-05
	for pgsql-hackers@arkaria.postgresql.org; Thu, 20 May 2021 21:37:58 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1ljqMf-0006yD-OB
	for pgsql-hackers@lists.postgresql.org; Thu, 20 May 2021 21:37:57 +0000
Received: from momjian.us ([72.94.173.45])
	by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1ljqMc-0002MN-TT
	for pgsql-hackers@postgresql.org; Thu, 20 May 2021 21:37:56 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1ljqMa-0007ah-DO; Thu, 20 May 2021 17:37:52 -0400
Date: Thu, 20 May 2021 17:37:52 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Justin Pryzby <pryzby@telsasoft.com>, pgsql-hackers@postgresql.org
Subject: Re: PG 14 release notes, first draft
Message-ID: <20210520213752.GF8971@momjian.us>
References: <20210520195902.GE8971@momjian.us>
 <20210520203507.GA21233@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210520203507.GA21233@alvherre.pgsql>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20210520213752.GF8971%40momjian.us>
Precedence: bulk

On Thu, May 20, 2021 at 04:35:07PM -0400, Álvaro Herrera wrote:
> On 2021-May-20, Bruce Momjian wrote:
> 
> > On Thu, May 20, 2021 at 02:55:18PM -0500, Justin Pryzby wrote:
> > > On Thu, May 20, 2021 at 03:44:46PM -0400, Bruce Momjian wrote:
> > > > > | Reduce the default value of vacuum_cost_page_miss (Peter Geoghegan) 
> > > > > |  This new default better reflects current hardware capabilities. 
> > > > > Also say: the previous default was 10.
> > > > 
> > > > Uh, we didn't report the new value, so why report the old one?
> > > 
> > > Good point.
> > > For symmetry with this one, maybe the old and new values should be included?
> > 
> > Not sure.  Those values are kind of hard to understand, so I am afraid
> > there would be more confusion by mentioning them.
> > 
> > > |Change checkpoint_completion_target default to 0.9 (Stephen Frost)
> > > |The previous default was 0.5.
> > 
> > Uh, that one is frequently modified by users, to an extent I didn't
> > understand why we kept it at 0.5 for so long, which is why I mentioned
> > it.
> 
> You also mentioned 'md5' in the entry about password_encryption,
> remember?  I tend to agree with Justin: if it's not too much extra space
> to mention both values, let's just do that.  "Reduce the value of X to Y
> from Z.  The new default better reflects ..." seems OK to me.
> 
> I prefer "to Y from Z" rather than "from Z to Y", because then the new
> value appears first, which seems a tiny improvement in readability,
> though the phrase is in the opposite order of traditional.  Also it
> seems better than "change value of X to Y.  The previous default was Z"
> because it then becomes a little more verbose than really needed.  But
> maybe that's OK too.

I went with this text:

	Reduce the default value of <varname><xref
	linkend="guc-vacuum-cost-page-miss"></varname> from 10 milliseconds to 2
	(Peter Geoghegan)

I think with numbers, and the fact we are saying "decrease" havint them
in the from/to order is best.  If this was non-numeric, like to scram
from md5, it would make more sense to use to/from.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.