Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llhC4-0000UG-Tr for pgsql-hackers@arkaria.postgresql.org; Wed, 26 May 2021 00:14:40 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1llhBX-0006u3-6n for pgsql-hackers@arkaria.postgresql.org; Wed, 26 May 2021 00:14:07 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1llhBW-0006tu-SX for pgsql-hackers@lists.postgresql.org; Wed, 26 May 2021 00:14:06 +0000 Received: from mail-io1-xd2f.google.com ([2607:f8b0:4864:20::d2f]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1llhBS-0001Ou-V8 for pgsql-hackers@postgresql.org; Wed, 26 May 2021 00:14:04 +0000 Received: by mail-io1-xd2f.google.com with SMTP id k16so33502266ios.10 for ; Tue, 25 May 2021 17:14:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=UGRvRvgdZBZP9nUR8/7+MQrpA+0/Yi5M4L4JJhwEA1w=; b=qG/z//NshpLz3/AXs6LV+7RU6M/Hb2uXqXZZWgvDzRXexC5WstPi4/1999v0js7/Wd seVrrgghPTZUssJGKz4VasOm5FemJdJuZrZYGZPoJnx5wdXRPRgNtAMCKVL08gMRMbkj L5RUL8XhbUkutJpF7c/Mf3Fshn1RXkKW4mhX4vyw2hyLY19bgSqLWv91Sepn6A41lub+ /XaI5/bWyX7YxROo0Fg3NElDT1m/6TEL9ZxjgXWvFHP9oRnC8cvwzmy+Cq2qnNOe2Xsl sQkJAqk8T3nFBPSDZ0EKvTCCIf3e5Mi/DUrqp8SrrupHFQKv7pydAQUyjapFAwIETVdt TLXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=UGRvRvgdZBZP9nUR8/7+MQrpA+0/Yi5M4L4JJhwEA1w=; b=tmQ9zu4yTGt+XS0740PxkMoRkvV/Gjozhq/pEMt3wc33nUcQHQNhpW1cKOD3yvCeAb jAeb+X3cJahH0uho2GbCqxHda9Zk4JEtkEZcCK/7Y08HmWeQTPHklw/Fi7yyhmGEcEP+ /92hHV/xvn/vAgq9Nx7TxQzQHfaGmZgDcAJhUeVNiwmBduukre0KpcRM7uzKsSTy8M7S 7zgsC2MQXELpaT4teBWZtWxQWME5PE0zygMHwhIAKTxOK1qhxh6gGSsJ3TpeumJn/U0t Wp2J/m5uxLNN4jB/AhoR7Qs84c7CbBLmhlMyo+v/p+nsNZrUDgeyMBNME1VTI+3FdSOy o/kQ== X-Gm-Message-State: AOAM531MXWoiS0U4RaWvNM46naOANeUlA9jdntDRrEOxjkVvN/WvylRo L97nWi5BK2tNp3Tjjm5dbpL+lg== X-Google-Smtp-Source: ABdhPJyjbvqi7Tu3yGFvvmJR0skY71p3QQaiQ4swNnwpMgalJ9s1n6R2XGUnPDrwLgpN/GJgAdQ4pw== X-Received: by 2002:a02:970c:: with SMTP id x12mr217478jai.21.1621988040856; Tue, 25 May 2021 17:14:00 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id t2sm8141526ilf.65.2021.05.25.17.14.00 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 25 May 2021 17:14:00 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id 726ED801407; Tue, 25 May 2021 19:13:59 -0500 (CDT) Date: Tue, 25 May 2021 19:13:59 -0500 From: Justin Pryzby To: Thomas Munro Cc: David Steele , Fujii Masao , Bruce Momjian , Paul Guo , Tom Lane , Michael Brown , pgsql-hackers@postgresql.org Subject: Re: fdatasync performance problem with large number of DB files Message-ID: <20210526001359.GE3676@telsasoft.com> References: <20210318135411.GB8529@momjian.us> <20210318140352.GC8529@momjian.us> <3d1086bd-0881-e0a3-9f4f-bda608f07fdb@oss.nttdata.com> <7716fafe-fcab-3faf-c337-d1e8c6ae6191@pgmasters.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Sat, Mar 20, 2021 at 12:16:27PM +1300, Thomas Munro wrote: > > > + { > > > + {"recovery_init_sync_method", PGC_POSTMASTER, ERROR_HANDLING_OPTIONS, > > > + gettext_noop("Sets the method for synchronizing the data directory before crash recovery."), > > > + }, Is there any reason why this can't be PGC_SIGHUP ? (Same as restart_after_crash, remove_temp_files_after_crash) As neat as it'd be, I am not expecting the recovery process to reload the configuration and finish fast if I send it HUP. While I'm looking, it's not clear why this needs to be PGC_POSTMASTER. data_sync_retry - but see b3a156858 This one isn't documented as requiring a restart: max_logical_replication_workers. ignore_invalid_pages could probably be SIGHUP, but it's intended to be used as a commandline option, not in a config file. -- Justin