Date: Wed, 26 May 2021 18:08:20 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
	Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for
 reduced size?
Message-ID: <202105262208.iwm6dxqv2puy@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1618250.1622059906@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202105262208.iwm6dxqv2puy%40alvherre.pgsql>
Precedence: bulk

On 2021-May-26, Tom Lane wrote:

> I wrote:
> > I think this is about ready to commit now (though I didn't yet nuke
> > GetDefaultToastCompression).
> 
> Here's a bundled-up final version, in case anybody would prefer
> to review it that way.

Looks good to me.

I tested the behavior with partitioned tables and it seems OK.

It would be good to have a test case in src/bin/pg_dump/t/002_pg_dump.pl
for the case ... and I find it odd that we don't seem to have anything
for the "CREATE TABLE foo (LIKE sometab INCLUDING stuff)" form of the
command ... but neither of those seem the fault of this patch, and they
both work as [I think] is intended.

-- 
Álvaro Herrera       Valdivia, Chile
"Estoy de acuerdo contigo en que la verdad absoluta no existe...
El problema es que la mentira sí existe y tu estás mintiendo" (G. Lama)