Date: Wed, 26 May 2021 19:44:03 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Michael Paquier <michael@paquier.xyz>,
	Justin Pryzby <pryzby@telsasoft.com>,
	Andres Freund <andres@anarazel.de>, pgsql-hackers@postgresql.org,
	Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: Move pg_attribute.attcompression to earlier in struct for
 reduced size?
Message-ID: <202105262344.uo3thib7lpml@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1666832.1622067703@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202105262344.uo3thib7lpml%40alvherre.pgsql>
Precedence: bulk

On 2021-May-26, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:

> > It would be good to have a test case in src/bin/pg_dump/t/002_pg_dump.pl
> > for the case
> 
> Personally I won't touch 002_pg_dump.pl with a 10-foot pole, but if
> somebody else wants to, have at it.

Nod.

> > ... and I find it odd that we don't seem to have anything
> > for the "CREATE TABLE foo (LIKE sometab INCLUDING stuff)" form of the
> > command ... but neither of those seem the fault of this patch, and they
> > both work as [I think] is intended.
> 
> Hm, there's this in compression.sql:
> 
> -- test LIKE INCLUDING COMPRESSION
> CREATE TABLE cmdata2 (LIKE cmdata1 INCLUDING COMPRESSION);
> \d+ cmdata2
> 
> Or did you mean the case with a partitioned table specifically?

Ah, I guess that's sufficient.  (The INCLUDING clause cannot be used to
create a partition, actually.)

-- 
Álvaro Herrera                            39°49'30"S 73°17'W
"Now I have my system running, not a byte was off the shelf;
It rarely breaks and when it does I fix the code myself.
It's stable, clean and elegant, and lightning fast as well,
And it doesn't cost a nickel, so Bill Gates can go to hell."