Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lpIb3-0004ka-Ee
	for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Jun 2021 22:47:21 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lpIb2-0003i1-55
	for pgsql-hackers@arkaria.postgresql.org; Fri, 04 Jun 2021 22:47:20 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lpIb1-0003gS-Sq
	for pgsql-hackers@lists.postgresql.org; Fri, 04 Jun 2021 22:47:19 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lpIaz-0002xh-Oo
	for pgsql-hackers@postgresql.org; Fri, 04 Jun 2021 22:47:18 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lpIay-00029m-KC; Fri, 04 Jun 2021 18:47:16 -0400
Date: Fri, 4 Jun 2021 18:47:16 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@postgresql.org
Subject: Re: PG 14 release notes, first draft
Message-ID: <20210604224716.GC7679@momjian.us>
References: <20210510060308.GC6088@momjian.us>
 <20210604213106.GR14099@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210604213106.GR14099@telsasoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20210604224716.GC7679%40momjian.us>
Precedence: bulk

On Fri, Jun  4, 2021 at 04:31:06PM -0500, Justin Pryzby wrote:
> doc/src/sgml/release-14.sgml-      <listitem>
> doc/src/sgml/release-14.sgml-<!--
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fujii@postgresql.org>
> doc/src/sgml/release-14.sgml-2020-10-02 [8d9a93596] Add pg_stat_wal statistics view.
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fujii@postgresql.org>
> doc/src/sgml/release-14.sgml-2020-12-02 [01469241b] Track total number of WAL records, FPIs and bytes genera
> doc/src/sgml/release-14.sgml-Author: Fujii Masao <fujii@postgresql.org>
> doc/src/sgml/release-14.sgml:2021-03-09 [ff99918c6] Track total amounts of times spent writing and syncing W
> doc/src/sgml/release-14.sgml--->
> doc/src/sgml/release-14.sgml-
> doc/src/sgml/release-14.sgml-       <para>
> doc/src/sgml/release-14.sgml-        Add system view <link
> doc/src/sgml/release-14.sgml-        linkend="monitoring-pg-stat-wal-view"><structname>pg_stat_wal</structname></link>
> doc/src/sgml/release-14.sgml-        which reports <acronym>WAL</acronym> activity (Masahiro Ikeda)
> doc/src/sgml/release-14.sgml-       </para>
> doc/src/sgml/release-14.sgml-      </listitem>
> 
> I think this should also mention the GUC:
> | track_wal_io_timing

This is part of this commit:

	commit ff99918c62
	Author: Fujii Masao <fujii@postgresql.org>
	Date:   Tue Mar 9 16:52:06 2021 +0900
	
	    Track total amounts of times spent writing and syncing WAL data to disk.
	
	    This commit adds new GUC track_wal_io_timing. When this is enabled,
	    the total amounts of time XLogWrite writes and issue_xlog_fsync syncs
	    WAL data to disk are counted in pg_stat_wal. This information would be
	    useful to check how much WAL write and sync affect the performance.

The feature is clearly the new system view pg_stat_wal.  The question is
whether we should also document that track_wal_io_timing adds timing
control to that new system view.  Normally we don't mention additional
features, like pg_dump support, for features we add in a major release. 
The documentation we link to from the release notes does mention
track_wal_io_timing.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.