Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpPRg-00063G-10 for pgsql-hackers@arkaria.postgresql.org; Sat, 05 Jun 2021 06:06:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lpPRe-00027q-RU for pgsql-hackers@arkaria.postgresql.org; Sat, 05 Jun 2021 06:06:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lpPRe-00027i-Bv for pgsql-hackers@lists.postgresql.org; Sat, 05 Jun 2021 06:06:06 +0000 Received: from mail-pj1-x102d.google.com ([2607:f8b0:4864:20::102d]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1lpPRZ-00072j-HB for pgsql-hackers@lists.postgresql.org; Sat, 05 Jun 2021 06:06:05 +0000 Received: by mail-pj1-x102d.google.com with SMTP id mp5-20020a17090b1905b029016dd057935fso444216pjb.5 for ; Fri, 04 Jun 2021 23:06:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=K9ISqE9yGLhhXLonxWI/QEgx8XULwCt4TOK4dGbFVf8=; b=IKOkI2QQ5CwqyHwwo79ibeCt7xrZ1y0IW/C2+kPzk/d+2rOJwnpVpUs6Fh9rfXu1lH ug+simoqKe4uAnFWtgkBqYq8kglA7JaVIEKRqVXj14fas48bZ5vthGhpd7B3uk2kPDxQ XNchrN5ivyq8vravHJuwKA9ICv/0RUOD7lrww= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=K9ISqE9yGLhhXLonxWI/QEgx8XULwCt4TOK4dGbFVf8=; b=BUpBe7uYG/ggfiAMXHE2N0w5EmZmmiNc/0xu+bu/udd71gB0cs2FeDY7ldAhZM/Q1s AlKR2+jcaOEr8ZBePGHp6sNVr5HusEKj1hrowUmByjv3lzRelew8oNdy1/NM8dr3WQjC pEyaXvnXayRoJCjUHzecF20JcV+2cTTBd7TGDC3dQc4oapfD5xO4Aq2xs2TVNudT9F9k pdTR7zclGcDJdTClYiugMFvTuKsXijbe8fEAVHhvjH52wC9LTcd1iEItb16E+G25B4up 0qZxUxTf2ZZUTsuXUpgnfbhpXC9Tl0vakB5j6PsDajyWhqt3aelk4ZqUSUNS15qY8Wvv x8QQ== X-Gm-Message-State: AOAM530AXEr5op2yUmyoSKnwuOChKgb5ufSQZQhzk2DXm7uNSiyKecHc J+sR8gJoJWik0dh5/z+6h8qvIw== X-Google-Smtp-Source: ABdhPJxOw6loSucNQnUyrXn3NzAwATRr7PFSm8q5aLewFvKQFo3RmXPZwgCHPH+ThCUci+bP4JPSCg== X-Received: by 2002:a17:90b:350a:: with SMTP id ls10mr8842190pjb.181.1622873159044; Fri, 04 Jun 2021 23:05:59 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id h18sm3382186pgl.87.2021.06.04.23.05.57 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 04 Jun 2021 23:05:58 -0700 (PDT) Date: Fri, 4 Jun 2021 23:05:55 -0700 From: Noah Misch To: Alvaro Herrera Cc: Tom Lane , Kyotaro Horiguchi , iwata.aya@fujitsu.com, tsunakawa.takay@fujitsu.com, k.jamison@fujitsu.com, pgsql-hackers@lists.postgresql.org Subject: Re: libpq debug log Message-ID: <20210605060555.GA216695@rfd.leadboat.com> References: <3928040.1617404844@sss.pgh.pa.us> <20210409211611.GA23762@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210409211611.GA23762@alvherre.pgsql> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Fri, Apr 09, 2021 at 05:16:11PM -0400, Alvaro Herrera wrote: > Pushed now. This added a PQtraceSetFlags() function. We have a dozen PQset*() functions, but this and PQresultSetInstanceData() are the only PQSomethingSet() functions. Is it okay if I rename it to PQsetTraceFlags()? I think that would be more idiomatic for libpq.