Date: Sat, 5 Jun 2021 11:02:49 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Noah Misch <noah@leadboat.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>, iwata.aya@fujitsu.com,
	tsunakawa.takay@fujitsu.com, k.jamison@fujitsu.com,
	pgsql-hackers@lists.postgresql.org
Subject: Re: libpq debug log
Message-ID: <202106051502.l252ugdz7cg6@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210605060555.GA216695@rfd.leadboat.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202106051502.l252ugdz7cg6%40alvherre.pgsql>
Precedence: bulk

On 2021-Jun-04, Noah Misch wrote:

> On Fri, Apr 09, 2021 at 05:16:11PM -0400, Alvaro Herrera wrote:
> > Pushed now.
> 
> This added a PQtraceSetFlags() function.  We have a dozen PQset*() functions,
> but this and PQresultSetInstanceData() are the only PQSomethingSet()
> functions.  Is it okay if I rename it to PQsetTraceFlags()?  I think that
> would be more idiomatic for libpq.

Hmm, there is an obvious parallel between PQtrace() and
PQtraceSetFlags() which is lost with your proposed rename.  I'm not
wedded to the name though, so I'm just -0.1 on the rename.  If you feel
strongly about it, I won't oppose it.

-- 
Álvaro Herrera       Valdivia, Chile
"La espina, desde que nace, ya pincha" (Proverbio africano)