Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lssny-0002fv-Do
	for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Jun 2021 20:03:30 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1lssnx-0004u0-4w
	for pgsql-hackers@arkaria.postgresql.org; Mon, 14 Jun 2021 20:03:29 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lssnw-0004qB-T3
	for pgsql-hackers@lists.postgresql.org; Mon, 14 Jun 2021 20:03:28 +0000
Received: from momjian.us ([72.94.173.45])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lssnt-0003ug-HO
	for pgsql-hackers@lists.postgresql.org; Mon, 14 Jun 2021 20:03:27 +0000
Received: from bruce by momjian.us with local (Exim 4.92)
	(envelope-from <bruce@momjian.us>)
	id 1lssnr-0002Gy-BB; Mon, 14 Jun 2021 16:03:23 -0400
Date: Mon, 14 Jun 2021 16:03:23 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: PG 14 release notes, first draft
Message-ID: <20210614200323.GD18585@momjian.us>
References: <20210510060308.GC6088@momjian.us>
 <20210519143908.GU373@telsasoft.com>
 <20210612004425.GQ16435@telsasoft.com>
 <20210612034551.GU16435@telsasoft.com>
 <20210614163758.GG31772@telsasoft.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210614163758.GG31772@telsasoft.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20210614200323.GD18585%40momjian.us>
Precedence: bulk

On Mon, Jun 14, 2021 at 11:37:58AM -0500, Justin Pryzby wrote:
> Some more:
> 
> | VACUUM now has a PROCESS_TOAST which can be set to false to disable TOAST processing, and vacuumdb has a --no-process-toast option. 
> has a process_toast *option

Agreed.

> | Previously, if the object already exists, EXPLAIN would fail. 
> already existed

Fixed.

> | Function pg_stat_reset_replication_slot() resets slot statistics. 
> *The function.  But maybe it should be omitted.

OK, I went with "The function".

> | New options are read-only, primary, standby, and prefer-standby. 
> *The new options

Agreed.

> | Allow reindexdb to change the tablespace of the new index (Michael Paquier)
> | This is done by specifying --tablespace.
> I think this should be merged with the corresponding server feature, like this one:
> |Add ability to skip vacuuming of TOAST tables (Nathan Bossart)
> |VACUUM now has a PROCESS_TOAST which can be set to false to disable TOAST processing, and vacuumdb has a --no-process-toast option. 
> 
> Or, the client-side option could be omitted.  This is distinguished from
> vacuumdb --no-index-cleanup and --no-truncate, for which the server support was
> added in v12, and the client support was essentially an omision.

I am inclined to mention reindexdb because we mention the SQL command
option in the text.  Here is the updated text:

	     <listitem>
	<!--
	Author: Michael Paquier <michael@paquier.xyz>
	2021-02-04 [c5b286047] Add TABLESPACE option to REINDEX
	Author: Michael Paquier <michael@paquier.xyz>
	2021-03-03 [57e6db706] Add - -tablespace option to reindexdb
	-->
	
	      <para>
	       Allow <link linkend="sql-reindex"><command>REINDEX</command></link>
	       to change the tablespace of the new index (Alexey Kondratov,
	       Michael Paquier, Justin Pryzby)
	      </para>
	
	      <para>
	       This is done by specifying a <literal>TABLESPACE</literal> clause.
	       A <option>--tablespace</option> option was also added to <link
	       linkend="app-reindexdb"><application>reindexdb</application></link>
	       to control this.
	     </listitem>

> | Add documentation for the factorial() function (Peter Eisentraut)
> | With the removal of the ! operator in this release, factorial() is the only built-in way to compute a factorial. 
> Could be ommited or collapsed into the other item.  I know Tom thinks that
> it's unnecesary to document changes to documentation.

Uh, I think we need both items.  We are removing a feature and asking
people to use an existing feature that was previously undocumented.  I
think having two items makes it clear that the feature existed in
previous releases.  I just tried merging them into one item and there
were just too many changes for it to be clear.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.