Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltMSm-00024r-PI for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jun 2021 03:43:36 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ltMSl-0000YX-P3 for pgsql-hackers@arkaria.postgresql.org; Wed, 16 Jun 2021 03:43:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ltMSl-0000YP-AL for pgsql-hackers@lists.postgresql.org; Wed, 16 Jun 2021 03:43:35 +0000 Received: from mail-pl1-x62c.google.com ([2607:f8b0:4864:20::62c]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1ltMSe-0002Hn-Tr for pgsql-hackers@lists.postgresql.org; Wed, 16 Jun 2021 03:43:34 +0000 Received: by mail-pl1-x62c.google.com with SMTP id x10so424001plg.3 for ; Tue, 15 Jun 2021 20:43:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=leadboat.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=vsbpSyClXEhVFHZAAY9Yeus/gD7qnrz7kqLfq6CFVyY=; b=Pp0voQZ+OrLd0NInbDsTPyy05QVsI5RwHqBovwwzqEe5lgVg9MsimepzQkVdeUisCO qShFDO8wTTgp7USyJIqV8OVSw2bFDGHWWvVStNq+Zj4FKH87YZDJuJES/Q6B/yXGnbCz X6TiteglC2wRF63i3Acx2eqJhccKzeQxm8lts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=vsbpSyClXEhVFHZAAY9Yeus/gD7qnrz7kqLfq6CFVyY=; b=ptgpOPANQJTJQBWWvJRMFxZlXlCRxw9MMQnemcpBPruxMGzghcrbT5pNRzu8Vf117p 8HWvwdc8o3JSR+iRCqIDKe9SSc3ON4wI+lBPc1/LXBDglvVr9lHSgppMfkrKjXyYKiLz DlyxyG8tP5Dh9VYkFlp6XXm5ZWdtQT0Qp6JWFhuM7fiW9ttNx4YY8Ty1Y8B6kNUlbJRM OEbzV6GjW95VIIArAgMCqIFOjYC+bBBm7C36OgjZEMrr6zx+WRgIBTZWB2iFYk/j9FXC FiiFzTCC3fM/tMNtoIUXWjpI9NaSzDNpZ8PRdk2WkjXX/5Mg6DBOTxD1MYt65NcZ8Yx7 ZWVw== X-Gm-Message-State: AOAM530bPo/n3TWtiCW6RIh9jk3WK7MI1NFxlEphmLw33HKiDhDxGdmK IBb1WUCt8qzTprDQrsFQ5j+mUA== X-Google-Smtp-Source: ABdhPJxAMBprj22lTwTBQxeVMgWzEXblPP9a6H73j1hEZIB9izR2YsqY3c1d5KNN3bvLTOvHvZLzmg== X-Received: by 2002:a17:90a:ab0c:: with SMTP id m12mr2687261pjq.179.1623815007643; Tue, 15 Jun 2021 20:43:27 -0700 (PDT) Received: from rfd.leadboat.com ([2600:1702:a20:5750::46]) by smtp.gmail.com with ESMTPSA id q13sm530716pff.13.2021.06.15.20.43.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 15 Jun 2021 20:43:26 -0700 (PDT) Date: Tue, 15 Jun 2021 20:43:23 -0700 From: Noah Misch To: Tom Lane Cc: Andres Freund , Alvaro Herrera , pgsql-hackers@lists.postgresql.org Subject: Re: Improving isolationtester's data output Message-ID: <20210616034323.GA965392@rfd.leadboat.com> References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> <583674.1623799585@sss.pgh.pa.us> <20210616013115.2otscs7rwictsolv@alap3.anarazel.de> <592938.1623807811@sss.pgh.pa.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <592938.1623807811@sss.pgh.pa.us> User-Agent: Mutt/1.5.24 (2015-08-30) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Jun 15, 2021 at 09:43:31PM -0400, Tom Lane wrote: > Andres Freund writes: > > On 2021-06-15 19:26:25 -0400, Tom Lane wrote: > >> Going forward it wouldn't be a problem, but back-patching isolation > >> test cases might find it annoying. On the other hand, my nearby > >> patch to improve isolation test stability is already going to create > >> issues of that sort. (Unless, dare I say it, we back-patch that.) > > > It might be worth to back-patch - aren't there some back branch cases of > > test instability? And perhaps more importantly, I'm sure we'll encounter > > cases of writing new isolation tests in the course of fixing bugs that > > we'd want to backpatch that are hard to make reliable without the new > > features? > > Yeah, there absolutely is a case to back-patch things like this. Whether > it's a strong enough case, I dunno. I'm probably too close to the patch > to have an unbiased opinion about that. > > However, a quick look through the commit history finds several places > where we complained about not being able to back-patch isolation tests to > before 9.6 because we hadn't back-patched that version's isolationtester > improvements. I found 6b802cfc7, 790026972, c88411995, 8b21b416e without > looking too hard. So that history certainly suggests that not > back-patching such test infrastructure is the Wrong Thing. I'm +1 for back-patching this class of change. I've wasted time adapting a back-patch's test case to account for non-back-patched test infrastructure changes. Every back-patch of test infrastructure has been a strict win from my perspective.