Date: Mon, 21 Jun 2021 19:19:27 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andrey Borodin <x4mmm@yandex-team.ru>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	Heikki Linnakangas <hlinnaka@iki.fi>, pgsql-hackers@postgresql.org,
	Thomas Munro <thomas.munro@gmail.com>, Peter Geoghegan <pg@bowt.ie>,
	Andres Freund <andres@anarazel.de>
Subject: Re: Different compression methods for FPI
Message-ID: <20210622001927.GE29179@telsasoft.com>
References: <YMg8hz/hpl8Qr3bM@paquier.xyz>
 <d220fdbf-c9fc-6408-ff2b-07f5a9a23e2c@enterprisedb.com>
 <20210615161456.GP31772@telsasoft.com>
 <YMlIXTq+aLidW96K@paquier.xyz>
 <YMmlvyVyAFlxZ+/H@paquier.xyz>
 <74CD8839-05DD-40F5-9609-58B79AD2151E@yandex-team.ru>
 <YMqjMyXA6NwiFeXg@paquier.xyz>
 <YMrvSry/jP0gyvFO@paquier.xyz>
 <5C10FAD9-DC15-45E5-BCF9-B179A1ABA82E@yandex-team.ru>
 <YNEqrhTr39Kj8f/t@paquier.xyz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YNEqrhTr39Kj8f/t@paquier.xyz>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210622001927.GE29179%40telsasoft.com>
Precedence: bulk

On Tue, Jun 22, 2021 at 09:11:26AM +0900, Michael Paquier wrote:
> On Sun, Jun 20, 2021 at 11:15:08PM +0500, Andrey Borodin wrote:
> > I have some small questions.
> > 
> > 1.
> > +			report_invalid_record(record, "image at %X/%X compressed with %s not supported, block %d",
> > +								  (uint32) (record->ReadRecPtr >> 32),
> > +								  (uint32) record->ReadRecPtr,
> > +								  "lz4",
> > +								  block_id);
> > Can we point out to user that the problem is in the build?
> 
> What about the following error then?  Say:
> "image at %X/%X compressed with LZ4 not supported by build, block
> %d".

The two similar, existing messages are:

+#define NO_LZ4_SUPPORT() \
+       ereport(ERROR, \
+                       (errcode(ERRCODE_FEATURE_NOT_SUPPORTED), \
+                        errmsg("unsupported LZ4 compression method"), \
+                        errdetail("This functionality requires the server to be built with lz4 support."), \
+                        errhint("You need to rebuild PostgreSQL using --with-lz4.")))

src/bin/pg_dump/pg_backup_archiver.c:                           fatal("cannot restore from compressed archive (compression not supported in this installation)");
src/bin/pg_dump/pg_backup_archiver.c:           pg_log_warning("archive is compressed, but this installation does not support compression -- no data will be available");
src/bin/pg_dump/pg_dump.c:              pg_log_warning("requested compression not available in this installation -- archive will be uncompressed");

-- 
Justin