Date: Sun, 27 Jun 2021 23:21:37 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Deparsing rewritten query
Message-ID: <20210627152137.3rwfmfswwfrxmlsr@nol>
References: <20210627041138.zklczwmu3ms4ufnk@nol>
 <3176554.1624804492@sss.pgh.pa.us>
 <20210627150343.zslwnw7g564f2zz4@nol>
 <8085.1624806845@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <8085.1624806845@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/20210627152137.3rwfmfswwfrxmlsr%40nol>
Precedence: bulk

On Sun, Jun 27, 2021 at 11:14:05AM -0400, Tom Lane wrote:
> Julien Rouhaud <rjuju123@gmail.com> writes:
> 
> > Agreed.  One the other hand having such a function in core may ensure that any
> > significant change in those area will keep an API to retrieve the final query
> > representation.
> 
> My point is precisely that I'm unwilling to make such a promise.
> 
> I do not buy that this capability is worth very much, given that
> we've gotten along fine without it for twenty-plus years.  If you
> want to have it as an internal, might-change-at-any-time API,
> that seems all right.

I'm totally fine with a might-change-at-any-time API, but not with a
might-disappear-at-anytime API.  If exposing get_query_def() can become
virtually useless in a few releases with no hope to get required in-core change
for retrieving the final query representation, I agree this we can stop the
discussion here.