Date: Tue, 29 Jun 2021 19:46:35 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>,
	Jacob Champion <pchampion@vmware.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
Message-ID: <202106292346.oggetdriqizn@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <503095.1624999168@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202106292346.oggetdriqizn%40alvherre.pgsql>
Precedence: bulk

On 2021-Jun-29, Tom Lane wrote:

> More troublingly, fossa reports this:
> 
> ! nm -A -g -u libpq.so.5.15 2>/dev/null | grep -v '_eprintf\\.o:' | grep -e abort -e exit
> libpq.so.5.15:                 U abort@@GLIBC_2.2.5
> 
> Where is that coming from?  hippopotamus and jay, which seem to
> be different compilers on the same physical machine, aren't showing
> it.  That'd lead to the conclusion that icc is injecting abort()
> calls of its own accord, which seems quite nasty.  Lacking an icc
> license, I can't poke into that more directly here.

I noticed that the coverage report is not updating, and lo and behold
it's failing this bit.

I can inspect the built files ... what exactly are you looking for?

-- 
Álvaro Herrera       Valdivia, Chile
<Schwern> It does it in a really, really complicated way
<crab> why does it need to be complicated?
<Schwern> Because it's MakeMaker.