Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyZMQ-0000wY-Tt for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jun 2021 12:30:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1lyZMP-00011B-Qb for pgsql-hackers@arkaria.postgresql.org; Wed, 30 Jun 2021 12:30:33 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyZMP-000113-1A for pgsql-hackers@lists.postgresql.org; Wed, 30 Jun 2021 12:30:33 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lyZMK-0008ND-6Y for pgsql-hackers@postgresql.org; Wed, 30 Jun 2021 12:30:32 +0000 Received: from compute2.internal (compute2.nyi.internal [10.202.2.42]) by mailout.nyi.internal (Postfix) with ESMTP id 262085C01C9; Wed, 30 Jun 2021 08:30:26 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 30 Jun 2021 08:30:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=J3xlfkc2SYt95S831F0sQGsx7c0XD2vkwM+apKHtB/A=; b=HuP17r+q PPiKNCmU/QnJeVsk+GPlmPcAOdx+r1DvpT1Pq+jTKz9I5rmOis+hgYAxCAOccFX0 CVHCBee0HsaxfTs9hIHr3cCwjbw6zLCUH2zebC/9XdR48x9jTNiAuia+UyPqAnuY P5vjSU9KCmr4IVrIdVonENVMLJkOjnV+2Dq6yXhWSsbm+eKHyPbTFaQMQmmzgV7Z L9sKkGMDrLDZHA0AQz1+dBVj4oTTcH4EPLulYV04Q3kLpxCPhBAOvIYw0HV7zICI NpXmEXyYfpLsZDKt2cHiMfdb/aSTUvGt1IcBLyhMJE5FPMXYFdIz9zgcXwhzs6pa v8zn3993rpd7Nw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrfeeivddghedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttddunecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpeelhedvhfehtdduueejlefggeejvdeugfejfeetffethfej geeivdekteekgeehgfenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmne cuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprghlvhhh vghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 30 Jun 2021 08:30:25 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 95D502A085A; Wed, 30 Jun 2021 08:30:22 -0400 (-04) Date: Wed, 30 Jun 2021 08:30:22 -0400 From: Alvaro Herrera To: Andrew Dunstan Cc: Michael Paquier , PostgreSQL-development Subject: Re: cleaning up PostgresNode.pm Message-ID: <202106301230.ztnrg5tii3ds@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Jun-30, Andrew Dunstan wrote: > On 6/30/21 12:35 AM, Michael Paquier wrote: > > On Mon, Jun 28, 2021 at 01:02:37PM -0400, Andrew Dunstan wrote: > > skip_equals is not used. The only caller of adjust_conf is > > PostgresNode itself. > > Well, nothing is using it right now :-) It's intended to be available to > subclasses. > > My current subclass code doesn't actually use skip_equals either, but > earlier revisions did. Think of modifying pg_hba.conf. I thought it was about recovery.conf ... -- Álvaro Herrera Valdivia, Chile https://www.EnterpriseDB.com/