Date: Mon, 5 Jul 2021 12:03:33 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: Nitin Jadhav <nitinjadhavpostgres@gmail.com>,
	Zhihong Yu <zyu@yugabyte.com>, pgsql-hackers@lists.postgresql.org
Subject: Re: Removed extra memory allocations from create_list_bounds
Message-ID: <20210705170333.GA21248@telsasoft.com>
References: 
 <CAMm1aWYFTqEio3bURzZh47jveiHRwgQTiSDvBORczNEz2duZ1Q@mail.gmail.com>
 <20210516170029.GB373@telsasoft.com>
 <CALNJ-vS4g3QNmPe8WcgBmJQOzS0K_OAujW_1T0J2JXqpBQoBFw@mail.gmail.com>
 <CAMm1aWYr9=qPCTeNzVCEbF=Nr=RLSnt_vdCDTm9VjLS5L5JuOw@mail.gmail.com>
 <20210517150310.GG373@telsasoft.com>
 <CAMm1aWb0KSOCHexbaeit7gy_p4Uhs18EWyBdPyis4bfw4ids7A@mail.gmail.com>
 <CAApHDvpouaAv6P+UHbwZ1OL=z1sBcf5vuMJXGauhBZZMEAHb2w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAApHDvpouaAv6P+UHbwZ1OL=z1sBcf5vuMJXGauhBZZMEAHb2w@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210705170333.GA21248%40telsasoft.com>
Precedence: bulk

Also, if you're going to remove the initializations here, maybe you'd also
change i and j to C99 "for" declarations like "for (int i=0, j=0; ...)"

-       PartitionListValue **all_values = NULL;
-       ListCell   *cell;
-       int                     i = 0;
-       int                     ndatums = 0;
+       PartitionListValue *all_values;
+       int                     i;
+       int                     j;
+       int                     ndatums;

Same in get_non_null_list_datum_count()

-- 
Justin