Date: Fri, 9 Jul 2021 13:29:29 -0700
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Michael Paquier <michael@paquier.xyz>,
	Jacob Champion <pchampion@vmware.com>,
	"pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>,
	Daniel Gustafsson <daniel@yesql.se>, info@cspug.cz
Subject: Re: Preventing abort() and exit() calls in libpq
Message-ID: <20210709202929.GA2963274@rfd.leadboat.com>
References: <202107021459.7c2dkzyg5lua@alvherre.pgsql>
 <819502.1625239217@sss.pgh.pa.us>
 <20210703001639.GB2374652@rfd.leadboat.com>
 <1231771.1625321413@sss.pgh.pa.us>
 <1233492.1625323559@sss.pgh.pa.us>
 <20210703214658.GA2421985@rfd.leadboat.com>
 <1288324.1625352260@sss.pgh.pa.us>
 <20210709095952.GA2945708@rfd.leadboat.com>
 <2093118.1625839578@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2093118.1625839578@sss.pgh.pa.us>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210709202929.GA2963274%40rfd.leadboat.com>
Precedence: bulk

On Fri, Jul 09, 2021 at 10:06:18AM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Sat, Jul 03, 2021 at 06:44:20PM -0400, Tom Lane wrote:
> >> That'd require buildfarm owner intervention, as well as intervention
> >> by users.  Which seems like exporting our problems onto them.  I'd
> >> really rather not go that way if we can avoid it.
> 
> > I like that goal, though we'll have to see how difficult it proves.  As of
> > today, a GNU/Linux user building against static OpenLDAP will get a failure,
> > right?  That would export work onto that user, spuriously.
> 
> As a former packager for Red Hat, my response would be "you're doing it
> wrong".  Nobody on any Linux distro should *ever* statically link code
> from one package into code from another, because they are going to create
> untold pain for themselves when (not if) the first package is updated.
> So I flat out reject that as a valid use-case.
> 
> It may be that that ethos is not so strongly baked-in on other platforms.

Packagers do face more rules than users generally.

> But I'm content to wait and see if there are complaints before rescinding
> the automatic test; and if there are, I'd prefer to deal with it by just
> backing off to running the test on Linux only.

Okay.

> > We'd get something like 95% of the value by running the test on one Windows
> > buildfarm member and one non-Windows buildfarm member.
> 
> True.  But that just brings up the point that we aren't running the test
> at all on MSVC builds right now.  I have no idea how to do that, do you?

I don't.  But coverage via non-MSVC Windows is good enough.

> > ...  A strategy not having either of those drawbacks would be to skip
> > the test if libpq.so contains a definition of libpq_unbind().
> 
> I assume you meant some OpenLDAP symbol?

Yeah, that was supposed to say ldap_unbind().