Date: Sun, 11 Jul 2021 21:48:57 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Euler Taveira <euler@eulerto.com>, Greg Nancarrow <gregn4422@gmail.com>,
	Amit Kapila <amit.kapila16@gmail.com>,
	Peter Smith <smithpb2250@gmail.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Peter Eisentraut <peter.eisentraut@enterprisedb.com>,
	=?utf-8?B?w5ZuZGVyIEthbGFjxLE=?= <onderkalaci@gmail.com>,
	japin <japinli@hotmail.com>, Michael Paquier <michael@paquier.xyz>,
	David Steele <david@pgmasters.net>,
	Craig Ringer <craig@2ndquadrant.com>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>,
	Amit Langote <amitlangote09@gmail.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: row filtering for logical replication
Message-ID: <202107120148.l4nueeibgynb@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <849ee491-bba3-c0ae-cc25-4fce1c03f105@enterprisedb.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202107120148.l4nueeibgynb%40alvherre.pgsql>
Precedence: bulk

Hi

Andres complained about the safety of doing general expression
evaluation in pgoutput; that was first in 

https://postgr.es/m/20210128022032.eq2qqc6zxkqn5syt@alap3.anarazel.de
where he described a possible approach to handle it by restricting
expressions to have limited shape; and later in
http://postgr.es/m/20210331191710.kqbiwe73lur7jo2e@alap3.anarazel.de

I was just scanning the patch trying to see if some sort of protection
had been added for this, but I couldn't find anything.  (Some functions
are under-commented, though).  So, is it there already, and if so what
is it?  And if it isn't, then I think it should definitely be put there
in some form.

Thanks

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/