Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6dkw-0001rK-D9 for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 18:49:14 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1m6dkP-0007Qy-KK for pgsql-hackers@arkaria.postgresql.org; Thu, 22 Jul 2021 18:48:41 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6dkO-0007Qo-OF for pgsql-hackers@lists.postgresql.org; Thu, 22 Jul 2021 18:48:41 +0000 Received: from out1-smtp.messagingengine.com ([66.111.4.25]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1m6dkL-000256-UA for pgsql-hackers@postgresql.org; Thu, 22 Jul 2021 18:48:39 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id C69495C013E; Thu, 22 Jul 2021 14:48:36 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Thu, 22 Jul 2021 14:48:36 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=JF+xGVi9PCDoyetiyVEDMMUD7FyaMM1seMQIqnvWwGM=; b=iPSDV/Jd s46woRBzVMW0pD81K8XoXKAs2wEORdHlpe91KKVEoGgZQ3ISg0PM6Ln6Tp9Nypib 3hBgtmsVRpMReIBOUx99HRyikGecuLkcL29N0YxN9GUgS/kLl/Lj/OPp71epBuiC QspnEV6gklsW6LarpxFXjlbQZweURgN2WpGc7uU1TJjUIyF1G+p0kJl7r40/1apy nNmqjymCXg7ahh35dHnJ6JSMOZkMvxufoJQU/x0+DDrebDIilgZfCxI9qhpAk3w7 MrJOIZ52SFfY8AtXMlA2+baZBe736wbqX61GV29qlZMtsQR7NZ8+jNvYxD+bw4+B NJHpcM91J9TirA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrfeeigdduudekucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfggtggugfgjsehtkeertddttdejnecuhfhrohhmpeetlhhvrghr ohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprdhorhhgqe enucggtffrrghtthgvrhhnpedvvddtveejteeftdehueeiteehvdejfeffhfeihfejgedu udfgjeevgfekuedtheenucffohhmrghinhepvghnthgvrhhprhhishgvuggsrdgtohhmpd hthhgvlhhinhhugihrvghvihgvfidrtghomhenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgvrhhrvgesrghlvhhhrdhnohdqihhprd horhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Thu, 22 Jul 2021 14:48:36 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id BBB622A09B6; Thu, 22 Jul 2021 14:48:32 -0400 (-04) Date: Thu, 22 Jul 2021 14:48:32 -0400 From: Alvaro Herrera To: Rahila Syed Cc: Tomas Vondra , Peter Smith , PostgreSQL-development Subject: Re: Column Filtering in Logical Replication Message-ID: <202107221848.igsyrgcz6lzb@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk One thing I just happened to notice is this part of your commit message : REPLICA IDENTITY columns are always replicated : irrespective of column names specification. ... for which you don't have any tests -- I mean, create a table with a certain REPLICA IDENTITY and later try to publish a set of columns that doesn't include all the columns in the replica identity, then verify that those columns are indeed published. Having said that, I'm not sure I agree with this design decision; what I think this is doing is hiding from the user the fact that they are publishing columns that they don't want to publish. I think as a user I would rather get an error in that case: ERROR: invalid column list in published set DETAIL: The set of published commands does not include all the replica identity columns. or something like that. Avoid possible nasty surprises of security- leaking nature. -- Álvaro Herrera 39°49'30"S 73°17'W — https://www.EnterpriseDB.com/ "On the other flipper, one wrong move and we're Fatal Exceptions" (T.U.X.: Term Unit X - http://www.thelinuxreview.com/TUX/)