Date: Tue, 27 Jul 2021 16:17:28 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Pg Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_settings.pending_restart not set when line removed
Message-ID: <202107272017.rueagj54fhmt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <273674.1627398036@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/202107272017.rueagj54fhmt%40alvherre.pgsql>
Precedence: bulk

On 2021-Jul-27, Tom Lane wrote:

> So maybe like
> 
>         if (gconf->context < PGC_SIGHUP)
>         {
> +           /* The removal can't be effective without a restart */
> +           gconf->status |= GUC_PENDING_RESTART;
>             ereport(elevel,
>                     (errcode(ERRCODE_CANT_CHANGE_RUNTIME_PARAM),

Thanks, done that way.

> One thing worth checking is whether the pending-restart flag
> gets cleared again if the DBA undoes the removal and again
> reloads.  I think the right thing will happen, but it'd be
> worthwhile to check.

I tested this -- it works correctly AFAICS.

Thanks!

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
Al principio era UNIX, y UNIX habló y dijo: "Hello world\n".
No dijo "Hello New Jersey\n", ni "Hello USA\n".