Date: Wed, 28 Jul 2021 21:52:36 -0400
From: Bruce Momjian <bruce@momjian.us>
To: "David G. Johnston" <david.g.johnston@gmail.com>
Cc: Dave Cramer <davecramer@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Message-ID: <20210729015236.GD9600@momjian.us>
References: 
 <CADK3HHKawwbOcGwMGnDuAf3-U8YfvTcS8jqDv3UM=niijs3MMA@mail.gmail.com>
 <CAKFQuwY9bAJ7m0eY7aRJxF8QLZFzTJE-yO9q2Ltg8JVv=RW+wA@mail.gmail.com>
 <CADK3HHL88084=-v_4ubFD4Jf2j+V8rjxLDnV1yLWn2bmVfn+Zw@mail.gmail.com>
 <CAKFQuwbyfEMqsei49aBgYvQtkiskBs2TEf9mVT=k6Yijk12J0A@mail.gmail.com>
 <CADK3HHJQ=GoGcH0u2Yf2Sbes+161xMwFd4FDNGzUViH4ncbeEw@mail.gmail.com>
 <3562835.1626291827@sss.pgh.pa.us>
 <CADK3HHJJm_EocOX5Jtvus2pYw_mSFH99t02fOP00K2D-hNfVRA@mail.gmail.com>
 <CAKFQuwZ7Cg3aD+oiBL7FE+F-tS_Bn5Lg4TqLpe-BxRoeazPS9w@mail.gmail.com>
 <CAKFQuwZhCVAhsjBX7vnBxAkK1XvzHci=J_-ibZyLpNtrt2fMcg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="qcHopEYAB45HaUaB"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAKFQuwZhCVAhsjBX7vnBxAkK1XvzHci=J_-ibZyLpNtrt2fMcg@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210729015236.GD9600%40momjian.us>
Precedence: bulk


--qcHopEYAB45HaUaB
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

On Thu, Jul 15, 2021 at 08:15:57AM -0700, David G. Johnston wrote:
> On Thursday, July 15, 2021, David G. Johnston <david.g.johnston@gmail.com>
>      My uncertainty revolves around core extensions since it seems odd to tell
>     the user to overwrite them with versions from an older version of
>     PostgreSQL.
> 
> Ok. Just re-read the docs a third time…no uncertainty regarding contrib
> now…following the first part of the instructions means that before one could
> re-run create extension they would need to restore the original contrib library
> files to avoid the new extension code using the old library.  So that whole
> part about recreation is inconsistent with the existing unchanged text.

I came up with the attached patch.

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.


--qcHopEYAB45HaUaB
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="pg_upgrade.diff"

diff --git a/doc/src/sgml/ref/pgupgrade.sgml b/doc/src/sgml/ref/pgupgrade.sgml
index a83c63cd98..c042300c8c 100644
--- a/doc/src/sgml/ref/pgupgrade.sgml
+++ b/doc/src/sgml/ref/pgupgrade.sgml
@@ -306,8 +306,9 @@ make prefix=/usr/local/pgsql.new install
      into the new cluster, e.g., <filename>pgcrypto.so</filename>,
      whether they are from <filename>contrib</filename>
      or some other source. Do not install the schema definitions, e.g.,
-     <command>CREATE EXTENSION pgcrypto</command>, because these will be upgraded
-     from the old cluster.
+     <command>CREATE EXTENSION pgcrypto</command>, because these will be copied
+     from the old cluster.  (Consider upgrading the extensions later
+     using <literal>ALTER EXTENSION...UPGRADE</literal>.)
      Also, any custom full text search files (dictionary, synonym,
      thesaurus, stop words) must also be copied to the new cluster.
     </para>

--qcHopEYAB45HaUaB--