Date: Thu, 29 Jul 2021 13:13:48 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Dave Cramer <davecramer@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>,
	Bruce Momjian <bruce@momjian.us>, Tom Lane <tgl@sss.pgh.pa.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Message-ID: <202107291713.63pnbaycna4w@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CADK3HHL2ieOVoD4z1DgC-nDc90_FmkAy601wGJrJ+rQ_2ixqRQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202107291713.63pnbaycna4w%40alvherre.pgsql>
Precedence: bulk

On 2021-Jul-29, Dave Cramer wrote:

> > If the old cluster used extensions those same extensions must be
> > installed in the new cluster via installation procedures specific
> > to, and documented by, each extension.  For contrib extensions it is
> > usually enough to install the -contrib package via the same method
> > you used to install the PostgreSQL server.
> 
> Well this is not strictly true. There are many extensions that would
> work just fine with the current pg_upgrade. It may not even be
> necessary to recompile them.

It is always necessary to recompile because of the PG_MODULE_MAGIC
declaration, which is mandatory and contains a check that the major
version matches.  Copying the original shared object never works.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/
"But static content is just dynamic content that isn't moving!"
                http://smylers.hates-software.com/2007/08/15/fe244d0c.html