Date: Fri, 30 Jul 2021 19:28:32 +0800
From: Julien Rouhaud <rjuju123@gmail.com>
To: Dave Cramer <davecramer@postgres.rocks>
Cc: Jan Wieck <jan@wi3ck.info>, Bruce Momjian <bruce@momjian.us>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly
Message-ID: <20210730112832.wt3zdv32gllohope@nol>
References: <c4fc0792-1736-63e2-2447-ee2ed6e96b5b@wi3ck.info>
 <20210729161432.GN9600@momjian.us>
 <CAOBaU_ZRhXZN9qfWfyO+8pSLX6McFVwLYoDcsMtpvhd0pdiz3g@mail.gmail.com>
 <c23c3355-e7a3-4fbe-2521-32d5944b48b3@wi3ck.info>
 <20210730020257.jpvunvworyqsaz43@nol>
 <CADK3HHJ4BmJqB+BLHa-UL464q0_dLxkTA6sB51JAp6DOMpfufw@mail.gmail.com>
 <20210730103945.nc2zl74v5czy2qwd@nol>
 <CADK3HHKz4ruqmqiph2cLvg53AibAPsEyen4uDXe1h5bu-nwWjg@mail.gmail.com>
 <20210730110728.tqt3oeohyvtuqqk7@nol>
 <CADK3HHJj3Zw7rHP=WzLKKg8_o-KmNH48gsxDaVPFB+gLzySBJg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CADK3HHJj3Zw7rHP=WzLKKg8_o-KmNH48gsxDaVPFB+gLzySBJg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20210730112832.wt3zdv32gllohope%40nol>
Precedence: bulk

On Fri, Jul 30, 2021 at 07:18:56AM -0400, Dave Cramer wrote:
> 
> So my understanding is that upgrade is going to run all of the SQL files
> from whatever version the original instance was up to the current version.
> 
> I'm at a loss as to how this would not work ? How do you upgrade your
> extension otherwise ?

Yes, but as I said twice only if the currently installed version is different
from the default version.  Otherwise ALTER EXTENSION UPGRADE is a no-op.

Just to be clear: I'm not arguing against automatically doing an ALTER
EXTENSION UPGRADE for all extensions in all databases during pg_upgrade (I'm
all for it), just that this specific corner case can't be solved by that
approach.