Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAx4T-0001uG-Pz for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Aug 2021 16:15:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mAx4S-0008M4-I7 for pgsql-hackers@arkaria.postgresql.org; Tue, 03 Aug 2021 16:15:12 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mAx39-0003nk-NN for pgsql-hackers@lists.postgresql.org; Tue, 03 Aug 2021 16:13:51 +0000 Received: from mail-il1-x129.google.com ([2607:f8b0:4864:20::129]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1mAx36-0004eL-Uy for pgsql-hackers@lists.postgresql.org; Tue, 03 Aug 2021 16:13:51 +0000 Received: by mail-il1-x129.google.com with SMTP id r5so19955891ilc.13 for ; Tue, 03 Aug 2021 09:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telsasoft-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=i8puNgJtwpMvAQaVVkbD6cyhvbEsKIxw2AQxcLqLG/4=; b=Nw3rMquQLo2bRJhF2n17BfyUs80CdDjyXeX5KXgW77fRijO7OB+gLmcc2+jA95sYjj uioUf/XdIB1uiFgtUzZKdy6t+8zmcfFDXLiYfrp4lS0F76lq+29Amy8hZwPuu141X4Hr V6xqANR1Kdaad7ToehXbKpzAHoNkM/K3XfNqTWce2xgGWLrlOl29FMjFLvcOvyl1Ydqw i2IqGoYZkvUK2k3SaS61gWk1tzTjs92KcBhwXk2k9C3VkBJdZGwdloQ1dwcvMsZl1jF5 VLIg+LIeMUleX6fGBs7jxkod0RhxuXDqxFm6Xz3nw6fBoUXGKHN/a07wy/LpqSGglT4R A2PA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=i8puNgJtwpMvAQaVVkbD6cyhvbEsKIxw2AQxcLqLG/4=; b=el2HmgDfFSWbxW3TXcu7ykyRv6h7rqd+7sOyFO9mbyBSpnzb6qbQIXHy+WUU7yBIPo TSXXzrFzCDpsfpEcJ1uK5U4V4KTJDN8R86qIPAhWK/vTCJBlfMqmaQFgJxKADEf/hac3 nepXZzefhF4dyu4/OvwULP9A3J7JKd+Cu0xkwMjCV5XSqJv0sdNItnXxSJYLJTD9PnaM a+//KL1wsJyA9v7rCQIh9U/0vekBFixwNBXolB4YKa86jPvuu9rvzl07wsNfRo3M5mA5 pV8Y98+xtf+3EmabnvDryWQOWFQ7PA5acrH2QcCTbfEU6WYg4JSD3kIi1x5tKZ3GUgbi GUuw== X-Gm-Message-State: AOAM533DpUa+hA9RgaKICiCnMd5Xwxn4ZAjzYeAPGHrzAH213YBLwhhO 7GQpcBsZFKac+BgLOyZXfE679A== X-Google-Smtp-Source: ABdhPJxVig2twrFmz2Eah+p9kVaht2GCAyQNLXVSQV27k+AcfQK/omFwZHMqJ2SY1kI7EEFu5Yuysw== X-Received: by 2002:a92:6f0a:: with SMTP id k10mr634051ilc.105.1628007227347; Tue, 03 Aug 2021 09:13:47 -0700 (PDT) Received: from pryzbyj.telsasoft (charmander.telsasoft.com. [50.244.222.1]) by smtp.gmail.com with ESMTPSA id x2sm9900808iob.45.2021.08.03.09.13.46 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 03 Aug 2021 09:13:46 -0700 (PDT) Received: by pryzbyj.telsasoft (Postfix, from userid 1000) id BD6EB800C0B; Tue, 3 Aug 2021 11:13:45 -0500 (CDT) Date: Tue, 3 Aug 2021 11:13:45 -0500 From: Justin Pryzby To: Bruce Momjian Cc: Tom Lane , Dave Cramer , Alvaro Herrera , "David G. Johnston" , pgsql-hackers@lists.postgresql.org Subject: Re: pg_upgrade does not upgrade pg_stat_statements properly Message-ID: <20210803161345.GZ12533@telsasoft.com> References: <20210729163448.GP9600@momjian.us> <202107291743.pqlj3s2uilfu@alvherre.pgsql> <20210729190645.GS9600@momjian.us> <915981.1627592484@sss.pgh.pa.us> <20210729221103.GV9600@momjian.us> <953847.1627597196@sss.pgh.pa.us> <20210730164006.GB9600@momjian.us> <20210803160047.GG3639@momjian.us> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210803160047.GG3639@momjian.us> User-Agent: Mutt/1.9.4 (2018-02-28) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Tue, Aug 03, 2021 at 12:00:47PM -0400, Bruce Momjian wrote: > Patch applied through 9.6. The comment seems to be a leftover from a copy pasto. + /* find hash indexes */ + res = executeQueryOrDie(conn, + "SELECT name " + "FROM pg_available_extensions " + "WHERE installed_version != default_version" + ); -- Justin