Date: Sun, 15 Aug 2021 20:31:01 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tomas Vondra <tomas.vondra@enterprisedb.com>
Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: PoC/WIP: Extended statistics on expressions
Message-ID: <20210816013101.GR10479@telsasoft.com>
References: <2f2a3b3b-93e4-723f-144e-bc21f10d6b61@enterprisedb.com>
 <20210118045331.GF8560@telsasoft.com>
 <CAEZATCVnQccV_Z7AuvbvquaOYxUj+cVFk48pPGASYHFjXWgW5g@mail.gmail.com>
 <3f20da4d-89dc-0912-98d2-b6f0ef06c87f@enterprisedb.com>
 <CAEZATCUuj5FPjtOU2=7Z2pTC8LEvrf79+Go7R8yQ+eE0ezfgfQ@mail.gmail.com>
 <f865af90-c19c-769e-8c65-19692e245479@enterprisedb.com>
 <20210122022958.GC27167@telsasoft.com>
 <acf27932-8159-8872-8fca-902c7a35b351@enterprisedb.com>
 <20210122040101.GF27167@telsasoft.com>
 <04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <04b100f9-201b-0bc8-c613-0f918451b599@enterprisedb.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210816013101.GR10479%40telsasoft.com>
Precedence: bulk

On 1/22/21 5:01 AM, Justin Pryzby wrote:
> > In any case, why are there so many parentheses ?

On Fri, Jan 22, 2021 at 02:09:04PM +0100, Tomas Vondra wrote:
> That's a bug in pg_get_statisticsobj_worker, probably. It shouldn't be
> adding extra parentheses, on top of what deparse_expression_pretty does.
> Will fix.

The extra parens are still here - is it intended ?

postgres=# CREATE STATISTICS s ON i, (1+i), (2+i) FROM t;
CREATE STATISTICS
postgres=# \d t
                 Table "public.t"
 Column |  Type   | Collation | Nullable | Default 
--------+---------+-----------+----------+---------
 i      | integer |           |          | 
Statistics objects:
    "public"."s" ON i, ((1 + i)), ((2 + i)) FROM t

-- 
Justin