Date: Thu, 26 Aug 2021 10:34:48 -0400
From: Bruce Momjian <bruce@momjian.us>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: Julien Rouhaud <rjuju123@gmail.com>,
	Denis Laxalde <denis.laxalde@dalibo.com>,
	Michael Paquier <michael@paquier.xyz>,
	Jehan-Guillaume de Rorthais <jgdr@dalibo.com>,
	Andres Freund <andres@anarazel.de>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: [PATCH] Disable bgworkers during servers start in pg_upgrade
Message-ID: <20210826143448.GD22637@momjian.us>
References: <20210127144132.215fe4bb@firost>
 <20210312082325.weltivlokfpc3gt2@nol>
 <e7d8042b-e5a2-6093-e20e-15743c1a2843@dalibo.com>
 <YSXUwqCdhJWjPl1S@paquier.xyz>
 <7d470953-07cb-f9dc-f7b3-d33697644b54@dalibo.com>
 <CAOBaU_Zh5K_kjCAX+OnwRMQ68SHSVSR5haF9R0Ud8hXk31Wk+Q@mail.gmail.com>
 <20210826130945.GB22637@momjian.us>
 <2CD2F784-E80C-4B0D-A038-A0D44DD4EDC4@yesql.se>
 <CAOBaU_bhhOJwY_49aLbnd873aR7HR0j-A2b_Zgk4AHJSifuSLA@mail.gmail.com>
 <30D4153D-8F40-4BB8-838B-142D2C4EB4F0@yesql.se>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <30D4153D-8F40-4BB8-838B-142D2C4EB4F0@yesql.se>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210826143448.GD22637%40momjian.us>
Precedence: bulk

On Thu, Aug 26, 2021 at 03:59:49PM +0200, Daniel Gustafsson wrote:
> > On 26 Aug 2021, at 15:43, Julien Rouhaud <rjuju123@gmail.com> wrote:
> > 
> > Le jeu. 26 août 2021 à 21:38, Daniel Gustafsson <daniel@yesql.se <mailto:daniel@yesql.se>> a écrit :
> > > On 26 Aug 2021, at 15:09, Bruce Momjian <bruce@momjian.us <mailto:bruce@momjian.us>> wrote:
> > 
> > > Basically, pg_upgrade has avoided any backend changes that could be
> > > controlled by GUCs and I am not sure we want to start adding such
> > > changes for just this.
> > 
> > In principle I think it’s sound to try to avoid backend changes where possible
> > without sacrificing robustness.
> > 
> > I agree, but it seems quite more likely that an extension relying on a bgworker changes this guc, compared to an extension forcing autovacuum to be on for instance. 
> 
> Agreed, in this particular case I think there is merit to the idea of enforcing
> it in the backend.

OK, works for me

-- 
  Bruce Momjian  <bruce@momjian.us>        https://momjian.us
  EDB                                      https://enterprisedb.com

  If only the physical world exists, free will is an illusion.