Date: Sat, 28 Aug 2021 16:03:41 -0400
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Justin Pryzby <pryzby@telsasoft.com>
Cc: Andres Freund <andres@anarazel.de>,
	Kyotaro HORIGUCHI <horiguchi.kyotaro@lab.ntt.co.jp>,
	yuzuko <yuzukohosoya@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	David Steele <david@pgmasters.net>,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	Daniel Gustafsson <daniel@yesql.se>,
	Amit Langote <amitlangote09@gmail.com>,
	Masahiko Sawada <masahiko.sawada@2ndquadrant.com>,
	Laurenz Albe <laurenz.albe@cybertec.at>,
	"pgsql-hackers@lists.postgresql.org" <pgsql-hackers@lists.postgresql.org>,
	Greg Stark <stark@mit.edu>
Subject: Re: Autovacuum on partitioned table (autoanalyze)
Message-ID: <202108282003.eg6peb4cwqp3@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <20210817113018.GG10479@telsasoft.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202108282003.eg6peb4cwqp3%40alvherre.pgsql>
Precedence: bulk

On 2021-Aug-17, Justin Pryzby wrote:

> I suggest the attached (which partially reverts the revert), to allow showing
> correct data for analyze_count and last_analyzed.

Yeah, that makes sense and my keeping of the pg_stat_all_tables entries
seems pretty useless without this change.  I have pushed a slightly
modified version of this to 14 and master.

> Arguably these should be reported as null in v14 for partitioned tables, since
> they're not "known to be zero", but rather "currently unpopulated".
> 
> n_mod_since_analyze | 0
> n_ins_since_vacuum  | 0

I don't disagree, but it's not easy to implement this at present.  I
think almost all counters should be nulls for partitioned tables.  For
some of them one could make a case that it'd be more convenient to
propagate numbers up from partitions.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/