Date: Mon, 30 Aug 2021 10:42:49 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
	David Rowley <drowley@postgresql.org>,
	pgsql-hackers@lists.postgresql.org
Subject: Re: pg_dump, ATTACH, and independently restorable child partitions
Message-ID: <20210830154249.GX26465@telsasoft.com>
References: <20201024195949.GL9241@telsasoft.com>
 <20201107021835.GA13348@alvherre.pgsql>
 <20201120152055.GF24784@telsasoft.com>
 <577158.1606347319@sss.pgh.pa.us>
 <20201202225013.GJ24052@telsasoft.com>
 <2168110.1607101985@sss.pgh.pa.us>
 <20201204180231.GD24052@telsasoft.com>
 <1094034.1610418498@sss.pgh.pa.us>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1094034.1610418498@sss.pgh.pa.us>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210830154249.GX26465%40telsasoft.com>
Precedence: bulk

On Wed, Nov 25, 2020 at 06:35:19PM -0500, Tom Lane wrote:
> What we'd need to do if we want this to work with direct-to-DB restore                                                                                                                                    
> is to split off the ATTACH PARTITION command as a separate TOC entry.                                                                                                                                     
> That doesn't seem amazingly difficult, and it would even offer the                                                                                                                                        
> possibility that you could extract the partition standalone without                                                                                                                                       
> having to ignore errors.  (You'd use -l/-L to select the CREATE TABLE,                                                                                                                                    
> the data, etc, but not the ATTACH object.)                                                                                                                                                                

On Mon, Jan 11, 2021 at 09:28:18PM -0500, Tom Lane wrote:
> Justin Pryzby <pryzby@telsasoft.com> writes:
> > [ v5-0001-pg_dump-output-separate-object-for-ALTER-TABLE.AT.patch ]
> 
> Pushed with mostly cosmetic edits.

Thanks for pushing (9a4c0e36f).

Should this be included in the release notes ?

It's a user-visible change visible in pg_restore -l.  Someone might be
surprised that the attach "object" needs to be included for restore -L to
behave the same as it use to.

--
-- Name: cdrs_2021_08_22; Type: TABLE ATTACH; Schema: child; Owner: telsasoft
--

7949; 1259 1635139558 TABLE child cdrs_2021_08_24 telsasoft
62164; 0 0 TABLE ATTACH child cdrs_2021_08_24 telsasoft
;       depends on: 7949

-- 
Justin