Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMCTX-0002hO-9t for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Sep 2021 16:55:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mMCTW-00037o-7h for pgsql-hackers@arkaria.postgresql.org; Fri, 03 Sep 2021 16:55:34 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMCTV-00037W-AB for pgsql-hackers@lists.postgresql.org; Fri, 03 Sep 2021 16:55:34 +0000 Received: from out4-smtp.messagingengine.com ([66.111.4.28]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mMCTS-00053K-Ol for pgsql-hackers@lists.postgresql.org; Fri, 03 Sep 2021 16:55:32 +0000 Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id B30095C0068; Fri, 3 Sep 2021 12:55:28 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute5.internal (MEProxy); Fri, 03 Sep 2021 12:55:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; bh=zf9KLp76CYzMewb7Jks0rn9NJ/xqXzbAJ2l8TvvbFn4=; b=njO/251+ 89lVM1BLWMCTTbhvNd0nILkVlGwzCeMB+UGNlAmZMjLodbQ92oT3dwHQkUm6WYeD aX2QzdwARXBTDSBIQOix68IPp0jQuPoqZ4C3ApMh1q1mgCXT75FOEBgphwZUZ8TJ JJa1u40Zb1poHMMT+oLDauOXYVANxMwZdSEXNaxJ84CpE7NjbEpPb/wpM1Y8I4oO y7+oMZrcfbwwg/xD/N1F/3+/Zfk0g8BRi3MHkoQ+cmvTOJj/V7QZbMKCW4gxInc7 SliBgTeVAhoCgGoYE7808TUmGhPM+yOCJmnwGOI/P0lNytMGivYrf7mmUzcsjDJk gktT+k68whcqBg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddruddvjedguddtgecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggugfgjsehtke ertddttdejnecuhfhrohhmpeetlhhvrghrohcujfgvrhhrvghrrgcuoegrlhhvhhgvrhhr vgesrghlvhhhrdhnohdqihhprdhorhhgqeenucggtffrrghtthgvrhhnpedujeevjeffje evuddutedvkeeiueeitddvieelfeekveejudefgeeuvdejhfeuleenucffohhmrghinhep vghnthgvrhhprhhishgvuggsrdgtohhmnecuvehluhhsthgvrhfuihiivgeptdenucfrrg hrrghmpehmrghilhhfrhhomheprghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhr gh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Sep 2021 12:55:26 -0400 (EDT) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id AE8C52A07D0; Fri, 3 Sep 2021 12:55:23 -0400 (-04) Date: Fri, 3 Sep 2021 12:55:23 -0400 From: Alvaro Herrera To: Kyotaro Horiguchi Cc: masao.fujii@oss.nttdata.com, andres@anarazel.de, pgsql-hackers@lists.postgresql.org, bossartn@amazon.com, mengjuan.cmj@alibaba-inc.com, Jakub.Wartak@tomtom.com Subject: Re: prevent immature WAL streaming Message-ID: <202109031655.3avkto3c36x4@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <202109031359.by2swmsx6ha2@alvherre.pgsql> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Oh, but of course we can't modify XLogReaderState in backbranches to add the new struct member abortedContrecordPtr (or whatever we end up naming that.) I think I'm going to fix this, in backbranches only, by having xlogreader.c have a global variable, which is going to be used by ReadRecord instead of accessing the struct member. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/