Date: Fri, 3 Sep 2021 20:03:45 -0400
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Cc: masao.fujii@oss.nttdata.com, andres@anarazel.de,
	pgsql-hackers@lists.postgresql.org, bossartn@amazon.com,
	mengjuan.cmj@alibaba-inc.com, Jakub.Wartak@tomtom.com
Subject: Re: prevent immature WAL streaming
Message-ID: <202109040003.mrmrswfamedu@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <202109040001.zky3wgv2qeqg@alvherre.pgsql>
Archived-At: 
 <https://www.postgresql.org/message-id/202109040003.mrmrswfamedu%40alvherre.pgsql>
Precedence: bulk

On 2021-Sep-03, Alvaro Herrera wrote:

> I thought that the way to have debug output for this new WAL code is to
> use WAL_DEBUG; that way it won't bother anyone and we can remove them
> later if necessary.
> 
> Also, I realized that we should cause any error in the path that
> assembles a record from contrecords is to set a flag that we can test
> after the standard "err:" label; no need to create a new label.
> 
> I also wrote a lot more comments to try and explain what is going on and
> why.
> 
> I'm still unsure about the two-flags reporting in xlogreader, so I put
> that in a separate commit.  Opinions on that one?
> 
> The last commit is something I noticed in pg_rewind ...

Oh, the pg_rewind tests died.  I fat-fingered the Assert conversion.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/