Date: Fri, 3 Sep 2021 21:23:27 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Nitin Jadhav <nitinjadhavpostgres@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>, Andres Freund <andres@anarazel.de>,
	Stephen Frost <sfrost@snowman.net>,
	Magnus Hagander <magnus@hagander.net>,
	Thomas Munro <thomas.munro@gmail.com>, pgsql-hackers@postgresql.org
Subject: Re: when the startup process doesn't (logging startup delays)
Message-ID: <20210904022327.GE26465@telsasoft.com>
References: 
 <CAMm1aWZScAOM4CA60sS90y3qPNtZ75Wo+6mRUry06bVjfRqePg@mail.gmail.com>
 <20210721131326.GA19620@telsasoft.com>
 <CAMm1aWb2OzbvOBxB-M+UUEXt0h2nmtNybo5x30b4vyCOLZB_dA@mail.gmail.com>
 <20210725175654.GA23997@telsasoft.com>
 <CA+TgmoY-0AUppRhiOGg1Bev+CwE_ZTajCDAY8B-wSLuw0KGC0w@mail.gmail.com>
 <20210726153023.GC23997@telsasoft.com>
 <20210814214700.GO10479@telsasoft.com>
 <CA+TgmoZtbqxaOLdpNkBcDbz=41tWALA8kpH4M=RWtPYHC7-KNg@mail.gmail.com>
 <CAMm1aWZrnYp1WocvoXcR2W2CGuqhgO+UjA9yz29kT6j1Axe=-w@mail.gmail.com>
 <CAMm1aWY6E+S2Q93yqvWGukZZ1SDR1tjEr_UAjeVFCqvqiQqseg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAMm1aWY6E+S2Q93yqvWGukZZ1SDR1tjEr_UAjeVFCqvqiQqseg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210904022327.GE26465%40telsasoft.com>
Precedence: bulk

On Fri, Sep 03, 2021 at 01:23:56PM +0530, Nitin Jadhav wrote:
> Please find the updated patch attached.

Please check CA+TgmoZtbqxaOLdpNkBcDbz=41tWALA8kpH4M=RWtPYHC7-KNg@mail.gmail.com

I agree with Robert that a standby server should not continuously show timing
messages for WAL replay.

Some doc comments:

+         Sets the time interval between each progress update of the operations
+         performed during startup process. This produces the log message after

Either say "performed by the startup process" or "performed during startup".

s/the/a/

+         every interval of time for the operations that take longer time. The unit

..for those operations which take longer than the specified duration.

+         used to specify the value is seconds. For example, if you set it to
+         <literal> 10s </literal>, then after every <literal> 10s </literal> there

remove "after"

+         is a log message indicating which operation is going on and what is the

say "..every 10s, a log is emitted indicating which operation is ongoing, and
the elapsed time from the beginning of the operation.."

+         elapsed time from beginning. If the value is set to <literal> 0 </literal>,
+         then it logs all the available messages for such operations. <literal> -1

"..then all messages for such operations are logged."

+         </literal> disables the feature. The default value is set to <literal> 10s
+         </literal>

"The default value is >10s<."