Date: Tue, 7 Sep 2021 08:16:53 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Fujii Masao <masao.fujii@oss.nttdata.com>
Cc: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>,
	pgsql-hackers@postgresql.org,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>,
	"rjuju123@gmail.com" <rjuju123@gmail.com>,
	Tom Lane <tgl@sss.pgh.pa.us>
Subject: Re: Improve logging when using Huge Pages
Message-ID: <20210907131653.GK26465@telsasoft.com>
References: 
 <CAOBaU_YGfFyruW4YX6++DifTtBt8bjatz0gMhaTRD=dqV3gdWg@mail.gmail.com>
 <7e5b9f6d-1db9-d1e2-3bd8-ef65f24b35be@oss.nttdata.com>
 <TU4PR8401MB1152CB4FEB99658BC6B35543EECF9@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
 <20210903.164934.1726669051525427478.horikyota.ntt@gmail.com>
 <1946f6b9-75a1-7aeb-7b06-6c018377e518@oss.nttdata.com>
 <2498302.1630679233@sss.pgh.pa.us>
 <f5d8ab35-a44d-2f28-b86f-cd939c1000c4@oss.nttdata.com>
 <TU4PR8401MB115257079749D8958A3450F7EED39@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
 <b707355a-84ba-9f8b-6026-8fac36121279@oss.nttdata.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b707355a-84ba-9f8b-6026-8fac36121279@oss.nttdata.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20210907131653.GK26465%40telsasoft.com>
Precedence: bulk

On Tue, Sep 07, 2021 at 07:12:36PM +0900, Fujii Masao wrote:
> One big concern about the patch is that log message is always reported
> when shared memory fails to be allocated with huge pages enabled
> when huge_pages=try. Since huge_pages=try is the default setting,
> many users would see this new log message whenever they start
> the server. Those who don't need huge pages but just use the default
> setting might think that such log messages would be noisy.

I don't see this as any issue.  We're only talking about a single message on
each restart, which would be added in a major release.  If it's a problem, the
message could be a NOTICE or INFO, and it won't be shown by default.

I think it should say "with/out huge pages" without "enabled/disabled", without
"again", and without "The server", like:

+                                       (errmsg("could not map anonymous shared memory (%zu bytes)"
+                                               " with huge pages.", allocsize),
+                                        errdetail("Anonymous shared memory will be mapped "
+                                               "without huge pages.")));

-- 
Justin