Date: Tue, 7 Sep 2021 21:00:11 -0700
From: Noah Misch <noah@leadboat.com>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: Michael Paquier <michael@paquier.xyz>,
	Robert Haas <robertmhaas@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>,
	Mark Dilger <mark.dilger@enterprisedb.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: Postgres perl module namespace
Message-ID: <20210908040011.GA2476997@rfd.leadboat.com>
References: <3967644.1628688608@sss.pgh.pa.us>
 <7b565e73-4adc-ee9f-bc61-34817298978d@dunslane.net>
 <CA+TgmobdrGo2PcxLYXr3DLVVHxt-Xp9dmkSsRuXSNRBasgrGxg@mail.gmail.com>
 <YSXZt7sJWJEz76F3@paquier.xyz>
 <CA+TgmoazCbbtxGEUaFFkArYxq_8r1iwL4kNG+fzJTzcDPRVfBw@mail.gmail.com>
 <ce3dc94c-2826-e2b3-42f7-dd0cecf9526c@dunslane.net>
 <20210904061949.GA2326091@rfd.leadboat.com>
 <da8a9278-3366-4871-4823-b929b3b5e91a@dunslane.net>
 <YTWiXYixl/bM0Gft@paquier.xyz>
 <780f82bb-3a25-0c6f-154a-9f24b9324dba@dunslane.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <780f82bb-3a25-0c6f-154a-9f24b9324dba@dunslane.net>
User-Agent: Mutt/1.5.24 (2015-08-30)
Archived-At: 
 <https://www.postgresql.org/message-id/20210908040011.GA2476997%40rfd.leadboat.com>
Precedence: bulk

On Tue, Sep 07, 2021 at 07:43:47AM -0400, Andrew Dunstan wrote:
> On 9/6/21 1:08 AM, Michael Paquier wrote:
> > On Sat, Sep 04, 2021 at 09:58:08AM -0400, Andrew Dunstan wrote:
> >> On 9/4/21 2:19 AM, Noah Misch wrote:
> >>> plperl uses PostgreSQL:: as the first component of its Perl module namespace.
> >>> We shouldn't use both PostgreSQL:: and Postgres:: in the same source tree, so
> >>> this change should not use Postgres::. 
> >> Good point. Here's the same thing using PostgreSQL::Test
> > A minor point: this introduces PostgreSQL::Test::PostgresVersion.
> > Could be this stripped down to PostgreSQL::Test::Version instead?
> 
> That name isn't very clear - what is it the version of, PostgreSQL or
> the test?

Fair.

> There's nothing very test-specific about this module - it simply
> encapsulates a Postgres version string. So maybe it should just be
> PostgreSQL::Version.

Could be fine, but that name could be useful as a CPAN module.  These modules
don't belong on CPAN, so I'd keep PostgreSQL::Test::PostgresVersion.  There's
only one reference in the tree, so optimizing that particular name is less
exciting.

(I wondered about using PGXS:: as the namespace for all these modules, since
it's short and "pgxs" is the closest thing to a name for the PostgreSQL build
system.  Overall, I didn't convince myself about it being an improvement.)