Date: Mon, 13 Sep 2021 13:52:39 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: "Drouvot, Bertrand" <bdrouvot@amazon.com>,
	PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>,
	Dilip Kumar <dilipbalaut@gmail.com>
Subject: Re: [BUG] Failed Assertion in ReorderBufferChangeMemoryUpdate()
Message-ID: <202109131652.i2mpy2tgxumt@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAA4eK1LfzPdTO73vW2qUkJeB1k1iL04rmqVJseBbF5qRAonmiw@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202109131652.i2mpy2tgxumt%40alvherre.pgsql>
Precedence: bulk

On 2021-Sep-06, Amit Kapila wrote:

> The error can occur at multiple places (like via palloc or various
> other places) between the first time we subtract the change_size and
> add it back after the change is re-computed. I think the correct fix
> would be that in the beginning we just compute the change_size by
> ReorderBufferChangeSize and then after re-computing the change, we
> just subtract the old change_size and add the new change_size. What do
> you think?

Am I the only that that thinks this code is doing far too much in a
PG_CATCH block?

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/
"Those who use electric razors are infidels destined to burn in hell while
we drink from rivers of beer, download free vids and mingle with naked
well shaved babes." (http://slashdot.org/comments.pl?sid=44793&cid=4647152)