Date: Wed, 15 Sep 2021 16:12:53 -0500
From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Cc: vignesh C <vignesh21@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>,
	Peter Geoghegan <pg@bowt.ie>,
	Tomas Vondra <tomas.vondra@2ndquadrant.com>
Subject: Re: Polyphase merge is obsolete
Message-ID: <20210915211253.GA17635@ahch-to>
References: <420a0ec7-602c-d406-1e75-1ef7ddc58d83@iki.fi>
 <264a0544-c4e9-315e-18fa-1afd9151e939@2ndquadrant.com>
 <6a15881f-0cc5-3564-abc0-03ec28883380@iki.fi>
 <4c6a8fd7-1902-fc8e-e8d6-281d426f5da8@iki.fi>
 <CALDaNm3K8iZh7zGKrSNHb4crGRdn3LsudgtEa=+Oz4LQE0SJOQ@mail.gmail.com>
 <91284957-3cb2-944e-5f14-5c2ff86b49fa@iki.fi>
 <20210911063527.GB3770@ahch-to>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20210911063527.GB3770@ahch-to>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20210915211253.GA17635%40ahch-to>
Precedence: bulk

On Sat, Sep 11, 2021 at 01:35:27AM -0500, Jaime Casanova wrote:
> On Wed, Jul 14, 2021 at 06:04:14PM +0300, Heikki Linnakangas wrote:
> > On 14/07/2021 15:12, vignesh C wrote:
> > > On Sat, Jan 23, 2021 at 3:49 AM Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> > > > Here's an updated version that fixes one bug:
> > > > 
> > > > The CFBot was reporting a failure on the FreeBSD system [1]. It turned
> > > > out to be an out-of-memory issue caused by an underflow bug in the
> > > > calculation of the size of the tape read buffer size. With a small
> > > > work_mem size, the memory left for tape buffers was negative, and that
> > > > wrapped around to a very large number. I believe that was not caught by
> > > > the other systems, because the other ones had enough memory for the
> > > > incorrectly-sized buffers anyway. That was the case on my laptop at
> > > > least. It did cause a big slowdown in the 'tuplesort' regression test
> > > > though, which I hadn't noticed.
> > > > 
> > > > The fix for that bug is here as a separate patch for easier review, but
> > > > I'll squash it before committing.
> > > 
> > > The patch does not apply on Head anymore, could you rebase and post a
> > > patch. I'm changing the status to "Waiting for Author".
> > 
> > Here's a rebased version. I also squashed that little bug fix from previous
> > patch set.
> > 
> 
> Hi,
> 
> This patch does not apply, can you submit a rebased version?
> 

BTW, I'm marking this one as "waiting on author"

-- 
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL