Date: Thu, 16 Sep 2021 09:44:35 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: vignesh C <vignesh21@gmail.com>, Rahila Syed <rahilasyed90@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Column Filtering in Logical Replication
Message-ID: <202109161244.e4ze4eaaj4b6@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAA4eK1Jci+3S-SKXjD3dnUQX_NAszMrdPcE1h2X0whjRtPhaGQ@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202109161244.e4ze4eaaj4b6%40alvherre.pgsql>
Precedence: bulk

On 2021-Sep-16, Amit Kapila wrote:

> I think the problem here is that with the proposed grammar we won't be
> always able to distinguish names at the gram.y stage. Some post
> parsing analysis is required to attribute the right type to name as is
> done in the patch.

Doesn't it work to stuff them all into RangeVars?  Then you don't need
to make the node type a monstrosity, just bail out in parse analysis if
an object spec has more elements in the RV than the object type allows.

-- 
Álvaro Herrera              Valdivia, Chile  —  https://www.EnterpriseDB.com/