Date: Thu, 16 Sep 2021 10:50:25 -0300
From: Alvaro Herrera <alvherre@alvh.no-ip.org>
To: vignesh C <vignesh21@gmail.com>
Cc: Amit Kapila <amit.kapila16@gmail.com>,
	Rahila Syed <rahilasyed90@gmail.com>,
	Tomas Vondra <tomas.vondra@enterprisedb.com>,
	Peter Smith <smithpb2250@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>
Subject: Re: Column Filtering in Logical Replication
Message-ID: <202109161350.kccziuuu25ex@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CALDaNm0tQKwRULvZONX1yqxjJ5CFNxficsr77C062GpCcooUjA@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/202109161350.kccziuuu25ex%40alvherre.pgsql>
Precedence: bulk

On 2021-Sep-16, vignesh C wrote:

> diff --git a/src/backend/parser/gram.y b/src/backend/parser/gram.y
> index e3068a374e..c50bb570ea 100644
> --- a/src/backend/parser/gram.y
> +++ b/src/backend/parser/gram.y

Yeah, on a quick glance this looks all wrong.  Your PublicationObjSpec
production should return a node with tag PublicationObjSpec, and
pubobj_expr should not exist at all -- that stuff is just making it all
more confusing.

I think it'd be something like this:

PublicationObjSpec:	
			ALL TABLES
					{
						$$ = makeNode(PublicationObjSpec);
						$$->pubobjtype = PUBLICATIONOBJ_ALL_TABLES;
						$$->location = @1;
					}
			| TABLE qualified_name
					{
						$$ = makeNode(PublicationObjSpec);
						$$->pubobjtype = PUBLICATIONOBJ_TABLE;
						$$->pubobj = $2;
						$$->location = @1;
					}
			| ALL TABLES IN_P SCHEMA name
					{
						$$ = makeNode(PublicationObjSpec);
						$$->pubobjtype = PUBLICATIONOBJ_ALL_TABLES_IN_SCHEMA;
						$$->pubobj = makeRangeVar( ... $5 ... );
						$$->location = @1;
					}
			| qualified_name
					{
						$$ = makeNode(PublicationObjSpec);
						$$->pubobjtype = PUBLICATIONOBJ_CONTINUATION;
						$$->pubobj = $1;
						$$->location = @1;
					};

You need a single object name under TABLE, not a list -- this was Tom's
point about needing post-processing to determine how to assign a type to
a object that's what I named PUBLICATIONOBJ_CONTINUATION here.

-- 
Álvaro Herrera         PostgreSQL Developer  —  https://www.EnterpriseDB.com/
"Puedes vivir sólo una vez, pero si lo haces bien, una vez es suficiente"