Date: Wed, 6 Oct 2021 19:26:51 -0500
From: Jaime Casanova <jcasanov@systemguards.com.ec>
To: Amul Sul <sulamul@gmail.com>
Cc: Rushabh Lathia <rushabh.lathia@gmail.com>,
	Robert Haas <robertmhaas@gmail.com>,
	Dilip Kumar <dilipbalaut@gmail.com>,
	Andres Freund <andres@anarazel.de>,
	Bharath Rupireddy <bharath.rupireddyforpostgres@gmail.com>,
	Ibrar Ahmed <ibrar.ahmad@gmail.com>,
	PostgreSQL-development <pgsql-hackers@postgresql.org>,
	Prabhat Sahu <prabhat.sahu@enterprisedb.com>
Subject: Re: [Patch] ALTER SYSTEM READ ONLY
Message-ID: <20211007002651.GA20716@ahch-to>
References: 
 <CAAJ_b97vxaTA-GZK4AyCJvrpzUsAhGLugXaYrE7mybb4FmOarw@mail.gmail.com>
 <CA+TgmoaPDkcNViu+jtgicBQ2WbHt5J_1P98Zq_00RUwDP5rwiQ@mail.gmail.com>
 <CA+TgmoYaMXTFV02rb-jyPshwAQV=5GLKX02-u-g6L+sJttXxVQ@mail.gmail.com>
 <CAAJ_b96G-oBxDC3C7Y72ER09bsheGHOxBK1HXHVOyHNXjTDmcA@mail.gmail.com>
 <CA+TgmoaScsuDcTYa_-pkBnVP5Xcb_vx0BX2qn6grnTt=+mmH6g@mail.gmail.com>
 <CAAJ_b96KcmmJw6rTEX_br485VYL1MAv89pJ31znctN8e6ri_cQ@mail.gmail.com>
 <CAAJ_b94WUtC2MU5EnDmx-Mhuw1xoN5xyHABbjJzoStP6DHsp9g@mail.gmail.com>
 <CA+Tgmob8zNB_pMr9X6=5syYYeAc9hUtZmZGRLOzW=Oyud3ho0A@mail.gmail.com>
 <CAGPqQf2n0aeeKMv+mA0zpgkqkamEVMCZE_VL74hxCe9hSNOQNg@mail.gmail.com>
 <CAAJ_b9549-u2qo4hgGcE94vcv6sTHUO_Eq+5vB1_-Av5QokJLw@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAAJ_b9549-u2qo4hgGcE94vcv6sTHUO_Eq+5vB1_-Av5QokJLw@mail.gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Archived-At: 
 <https://www.postgresql.org/message-id/20211007002651.GA20716%40ahch-to>
Precedence: bulk

On Tue, Oct 05, 2021 at 04:11:58PM +0530, Amul Sul wrote:
>    On Mon, Oct 4, 2021 at 1:57 PM Rushabh Lathia
> <rushabh.lathia@gmail.com> wrote:
> >
> > I tried to apply the patch on the master branch head and it's failing
> > with conflicts.
> >
> 
> Thanks, Rushabh, for the quick check, I have attached a rebased version for the
> latest master head commit # f6b5d05ba9a.
> 

Hi,

I got this error while executing "make check" on src/test/recovery:

"""
t/026_overwrite_contrecord.pl ........ 1/3 # poll_query_until timed out executing this query:
# SELECT '0/201D4D8'::pg_lsn <= pg_last_wal_replay_lsn()
# expecting this output:
# t
# last actual query output:
# f
# with stderr:
# Looks like your test exited with 29 just after 1.
t/026_overwrite_contrecord.pl ........ Dubious, test returned 29 (wstat 7424, 0x1d00)
Failed 2/3 subtests 

Test Summary Report
-------------------
t/026_overwrite_contrecord.pl      (Wstat: 7424 Tests: 1 Failed: 0)
  Non-zero exit status: 29
  Parse errors: Bad plan.  You planned 3 tests but ran 1.
Files=26, Tests=279, 400 wallclock secs ( 0.27 usr  0.10 sys + 73.78 cusr 59.66 csys = 133.81 CPU)
Result: FAIL
make: *** [Makefile:23: check] Error 1
"""


-- 
Jaime Casanova
Director de Servicios Profesionales
SystemGuards - Consultores de PostgreSQL