Date: Tue, 12 Oct 2021 16:54:35 -0700
From: Andres Freund <andres@anarazel.de>
To: Josef =?utf-8?B?xaBpbcOhbmVr?= <josef.simanek@gmail.com>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: [RFC] building postgres with meson
Message-ID: <20211012235435.ozcmsvosdziala7f@alap3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <CAFp7QwrqaRkMju9FHfZ35b2Xz0ATa035Bdw1ZXgrJ4xpr3TN4g@mail.gmail.com>
 <20211012171734.v6njkirzk5e7a6yt@alap3.anarazel.de>
 <CAFp7QwrBTaEzSLve+W_8748xyVqmSpYX46fBt+hGeugj+R4F7w@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <CAFp7QwrBTaEzSLve+W_8748xyVqmSpYX46fBt+hGeugj+R4F7w@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20211012235435.ozcmsvosdziala7f%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-10-13 01:19:27 +0200, Josef Šimánek wrote:
> I tried to clean and start from scratch, but I'm getting different
> error probably related to wrongly configured JIT (LLVM wasn't found
> during meson setup). I'll debug on my side to provide more info.

../src/backend/jit/jit.c:91:73: error: ‘DLSUFFIX’ undeclared (first use in this function)
   91 |         snprintf(path, MAXPGPATH, "%s/%s%s", pkglib_path, jit_provider, DLSUFFIX);
      |                                                                         ^~~~~~~~

This *very* likely is related to building in a source tree that also contains
a "non-meson" build "in place". The problem is that the meson build picks up
the pg_config.h generated by ./configure in the "normal" build, rather than
the one meson generated itself.

You'd need to execute make distclean or such, or use a separate git checkout.

I forgot about this issue because I only ever build postgres from outside the
source-tree (by invoking configure from a separate directory), so there's
never build products in it. I think at least I need to make the build emit a
warning / error if there's a pg_config.h in the source tree...


This is the part of the jit code that's built regardless of llvm availability
- you'd get the same error in a few other places unrelated to jit.

Greetings,

Andres Freund