Date: Wed, 13 Oct 2021 10:42:46 -0700
From: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [RFC] building postgres with meson
Message-ID: <20211013174246.zgp2sxdqsulhepea@alap3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <CAFBsxsHwt7fvLKMCNkJQex-TpYb+CuX1RSBxbCEQ4Lb_FtgsVA@mail.gmail.com>
 <20211012205945.tkr6nam4ej2swram@alap3.anarazel.de>
 <CAFBsxsGOeT1cKp6iVjTTWQL+Vwt3cZgV4nOK2+zju4OLv6+TmA@mail.gmail.com>
 <20211013163721.oqwvztktwsym3iu4@alap3.anarazel.de>
 <CAFBsxsEqZ1cCayUEd6nS7sS9Pv29G-hkJLbqE1wUmtG1AP4xcg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAFBsxsEqZ1cCayUEd6nS7sS9Pv29G-hkJLbqE1wUmtG1AP4xcg@mail.gmail.com>
Archived-At: 
 <https://www.postgresql.org/message-id/20211013174246.zgp2sxdqsulhepea%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-10-13 13:19:36 -0400, John Naylor wrote:
> On Wed, Oct 13, 2021 at 12:37 PM Andres Freund <andres@anarazel.de> wrote:
> 
> > For the autoconf build CI currently does something similar via
> >         LIBS="/usr/local/lib:$LIBS"
> >         INCLUDES="/usr/local/include:$INCLUDES"
> > ...
> >         LIBS="/usr/local/opt/openldap/lib:$LIBS"
> >         INCLUDES="/usr/local/opt/openldap/include:$INCLUDES"
> >         ...
> >           --with-includes="$INCLUDES" \
> >           --with-libs="$LIBS" \
> >
> > are you doing something like that? Or does it work for you without? I
> vaguely
> > recall hitting a similar problem as you report when not passing
> > /usr/local/... to configure.
> 
> I didn't do anything like that for the autoconf build. I have in the past
> done things retail, like

I'll try to see how this works / what causes the breakage.


> Somehow our emails got lower-cased down here, but I tried it with capital D:

:)


> meson configure -Dldap=disabled
>
> inside the build dir and got this:
>
> ../meson.build:278:2: ERROR: Tried to assign the invalid value "None" of
> type NoneType to variable.
>
> Line 278 is
>
>   ldap_r = ldap = dependency('', required : false)

Oops, I broke that when trying to clean things up. I guess I write too much C
;). It needs to be two lines.

I pushed the fix for that.

Greetings,

Andres Freund