Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1md0Ve-0001gX-6n
	for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Oct 2021 01:35:14 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-hackers-owner+archive@lists.postgresql.org>)
	id 1md0Vd-0003Xb-4b
	for pgsql-hackers@arkaria.postgresql.org; Wed, 20 Oct 2021 01:35:13 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1md0Vb-0003XI-7u
	for pgsql-hackers@lists.postgresql.org; Wed, 20 Oct 2021 01:35:12 +0000
Received: from wout1-smtp.messagingengine.com ([64.147.123.24])
	by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <andres@anarazel.de>)
	id 1md0VY-0005Wm-K2
	for pgsql-hackers@postgresql.org; Wed, 20 Oct 2021 01:35:10 +0000
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
	by mailout.west.internal (Postfix) with ESMTP id 157C63201EAD;
	Tue, 19 Oct 2021 21:35:07 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
  by compute1.internal (MEProxy); Tue, 19 Oct 2021 21:35:07 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=anarazel.de; h=
	date:from:to:cc:subject:message-id:references:mime-version
	:content-type:in-reply-to; s=fm2; bh=nRyfff0ZUrW974Fgc667L/U87xc
	3FDRW5eA7gSWJ20Q=; b=n+yaJFWYsgu8pZ7Oth7Rgpptlb0u7MDe7mHSNoztSr7
	5R+/Yj5OpHzev1hGBL3irelQ4vfrklopMQ/9raizXZWp2aYn9IRgjYVpxxh+WTB+
	pBsO+h22Kfcq2mT6DxaststUtkumeWHkDphiQ4Fn5Auc9llrrW31XWUr6KuI0ftU
	6OPXryxhe9mrkNFbLA/qJ9KJDrdUFCj9vQ+JHk40v5SfvOhYfogeqdJiyaIy/LbZ
	8SBKCrz3lLC9x6luedTghyzDMmdjU+IHwZWGc3LRJc1aWaySDIwe0e+gw2ywlJNE
	dKV4EAt7u0jiag60XQJA1lMzbso+QVFtkvWtwXnhwEg==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
	messagingengine.com; h=cc:content-type:date:from:in-reply-to
	:message-id:mime-version:references:subject:to:x-me-proxy
	:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=nRyfff
	0ZUrW974Fgc667L/U87xc3FDRW5eA7gSWJ20Q=; b=dvGGQFV9IUwKiIgwG/WJLf
	T06l+bWy72RdummM4s48NmhcVd+gd2cqsHfHWAgp6P8eMAldy35BYt0P+VUbTUsF
	YBheWux3sl4cfAbl6mJZAEElkSudCMIuj5/koPdzFVjozIMAKiVfHO1Yx6nuloW9
	pFU5+ZewnSjEy0iAAaZ65WXQUaxefoyeikzEFKfSYzEL+RW3+JVSKWjixV/U2FbV
	94BQXe2X7RlumutsJj8don17ygQkZt/+EM7fp9JUJ0P2hqLQS/OtNGwgBMgKIoJ+
	Gtf5GCwXZd+qCklf0ZjFK4oMdrs8ym46nByDmkOtkQ8OHsvk8VvyGcrhlyFAYvHQ
	==
X-ME-Sender: <xms:SnJvYctQMhG6oWEWWXZrnpZAItNp6YlLsUYm2W2P3yHqE3wisMc3IA>
    <xme:SnJvYZfkHFQBEAoFxxE33Zr-MfTQ7Qz1lwKLKH3Ifu63hg___BudviL2VGueNkfK8
    3OueuUnskVxFlUAXw>
X-ME-Received: 
 <xmr:SnJvYXxWQWrvSUVrlyovjpF_AlE6FvyenHmBwAZFuDZxOFLVlRc2nIwWQVSu_iZAeEUS_ULd62zvDcSBeujmKPGqpO-l_kWDjPQzS304S2TjS_CarnWP354Bnorm>
X-ME-Proxy-Cause: 
 gggruggvucftvghtrhhoucdtuddrgedvtddrvddvfedggeefucetufdoteggodetrfdotf
    fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
    uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
    cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpeetnhgurhgv
    shcuhfhrvghunhguuceorghnughrvghssegrnhgrrhgriigvlhdruggvqeenucggtffrrg
    htthgvrhhnpedukefhkeelueegveetheelffffjeegleeuudelfeefuedtleffueejfffh
    ueffudenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpe
    grnhgurhgvshesrghnrghrrgiivghlrdguvg
X-ME-Proxy: <xmx:SnJvYfOmuHhipi6h5_ve_-PESpQHoV_tmtBKN9GQmGBFqz2MMv4RLg>
    <xmx:SnJvYc8r5SoMsXLtcZsYFgNl8INrJEIcFEcZv1zaH-qc8b-gdm7Aow>
    <xmx:SnJvYXU9qo6zT25w49D10LLHl9eFOQrE9HfBKexE7VBy38Zvh172Sw>
    <xmx:SnJvYal99GhihMgh6eOjgZgb5aUCB4ANNIt2KxBf-I9NI1Y4HmcagQ>
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue,
 19 Oct 2021 21:35:06 -0400 (EDT)
Date: Tue, 19 Oct 2021 18:35:05 -0700
From: Andres Freund <andres@anarazel.de>
To: John Naylor <john.naylor@enterprisedb.com>
Cc: Thomas Munro <thomas.munro@gmail.com>,
	pgsql-hackers <pgsql-hackers@postgresql.org>
Subject: Re: [RFC] building postgres with meson
Message-ID: <20211020013505.4zpavnjeng7uithz@alap3.anarazel.de>
References: <20211012083721.hvixq4pnh2pixr3j@alap3.anarazel.de>
 <20211019183419.nsbr5n652n3sfqpv@alap3.anarazel.de>
 <1949598.1634671335@sss.pgh.pa.us>
 <CAFBsxsF3qasUjUrpsV5Ld1Q41A1YERJeUaUoc4zu0aGBfWOUrA@mail.gmail.com>
 <20211020003122.76lerm34nosgouev@alap3.anarazel.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20211020003122.76lerm34nosgouev@alap3.anarazel.de>
List-Id: <pgsql-hackers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-hackers@lists.postgresql.org>
List-Owner: <mailto:pgsql-hackers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-hackers>
Archived-At: 
 <https://www.postgresql.org/message-id/20211020013505.4zpavnjeng7uithz%40alap3.anarazel.de>
Precedence: bulk

Hi,

On 2021-10-19 17:31:22 -0700, Andres Freund wrote:
> I also need to make meson use our flex wrapper for the relevant versions... I
> can see the warning that'd be fixed by it on macos CI. Will do that and push
> it out to my github repo together with your changes.

That turned out to be more work than I anticipated, so I pushed your changes
out separately.

There's this bit in plflex.pl that talks about adjusting yywrap() for msvc. I
didn't implement that and didn't see any compilation problems. Looks like that
originally hails from 2011, in 08a0c2dabc3b9d59d72d7a79ed867b8e37d275a7

Hm. Seems not worth carrying forward unless it actually causes trouble?

Greetings,

Andres Freund