Date: Thu, 21 Oct 2021 21:38:15 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: "Shinoda, Noriyoshi (PN Japan FSIP)" <noriyoshi.shinoda@hpe.com>
Cc: masao.fujii@oss.nttdata.com, pgsql-hackers@postgresql.org,
	rjuju123@gmail.com, tgl@sss.pgh.pa.us,
	Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Subject: Re: Improve logging when using Huge Pages
Message-ID: <20211022023815.GI741@telsasoft.com>
References: 
 <TU4PR8401MB1152B1A4158D609472ABD51DEEA09@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
 <80872660-ad16-3040-0a25-bd741faa5fc0@oss.nttdata.com>
 <20210922002322.GS831@telsasoft.com>
 <20210927.114023.1519840069762071193.horikyota.ntt@gmail.com>
 <TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <TU4PR8401MB11529A0C57CEDCCBC39050EDEEA79@TU4PR8401MB1152.NAMPRD84.PROD.OUTLOOK.COM>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211022023815.GI741%40telsasoft.com>
Precedence: bulk

+               ereport(LOG, (errmsg("Anonymous shared memory was allocated %s huge pages.", with_hugepages ? "with" : "without")));

You shouldn't break a sentence into pieces like this, since it breaks
translation.  You don't want an untranslated "without" to appear in the middle
of the translated message.

There are cases where a component *shouldn't* be translated, like this one:
where "numeric" should not be translated.

src/backend/utils/adt/numeric.c:                                         errmsg("invalid input syntax for type %s: \"%s\"",
src/backend/utils/adt/numeric.c-                                                        "numeric", str)));

-- 
Justin