Date: Tue, 2 Nov 2021 15:23:53 -0500
From: Justin Pryzby <pryzby@telsasoft.com>
To: Melanie Plageman <melanieplageman@gmail.com>
Cc: pgsql-hackers@postgresql.org, Andres Freund <andres@anarazel.de>,
	Alvaro Herrera <alvherre@alvh.no-ip.org>
Subject: Re: make tuplestore helper function
Message-ID: <20211102202353.GG17618@telsasoft.com>
References: 
 <CAAKRu_azyd1Z3W_r7Ou4sorTjRCs+PxeHw1CWJeXKofkE6TuZg@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: 
 <CAAKRu_azyd1Z3W_r7Ou4sorTjRCs+PxeHw1CWJeXKofkE6TuZg@mail.gmail.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Archived-At: 
 <https://www.postgresql.org/message-id/20211102202353.GG17618%40telsasoft.com>
Precedence: bulk

Several places have a conditional value for the first argument (randomAccess),
but your patch changes the behavior to a constant "true".  I didn't review the
patch beyond that.

> @@ -740,18 +724,14 @@ pg_prepared_statement(PG_FUNCTION_ARGS)
> -	tupstore =
> -		tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> @@ -2701,42 +2701,13 @@ pg_hba_file_rules(PG_FUNCTION_ARGS)
> -	tuple_store =
> -		tuplestore_begin_heap(rsi->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> @@ -4799,31 +4797,8 @@ pg_timezone_names(PG_FUNCTION_ARGS)
> -	randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> -	tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);

> @@ -575,38 +575,12 @@ pg_ls_dir_1arg(PG_FUNCTION_ARGS)
> -	randomAccess = (rsinfo->allowedModes & SFRM_Materialize_Random) != 0;
> -	tupstore = tuplestore_begin_heap(randomAccess, false, work_mem);

> @@ -1170,17 +1154,12 @@ pg_cursor(PG_FUNCTION_ARGS)
> -	tupstore =
> -		tuplestore_begin_heap(rsinfo->allowedModes & SFRM_Materialize_Random,
> -							  false, work_mem);

> +++ b/src/backend/utils/fmgr/funcapi.c
> +	tupstore = tuplestore_begin_heap(true, false, maxKBytes);

-- 
Justin