Date: Sat, 13 Nov 2021 12:23:37 -0300
From: =?utf-8?Q?=C3=81lvaro?= Herrera <alvherre@alvh.no-ip.org>
To: Daniel Westermann <dwe@dbi-services.com>
Cc: pgsql-hackers@lists.postgresql.org,
	Simon Riggs <simon.riggs@enterprisedb.com>,
	Amit Langote <amitlangote09@gmail.com>,
	Pavan Deolasee <pavan.deolasee@gmail.com>
Subject: Re: support for MERGE
Message-ID: <202111131523.jt7xzphdwc7b@alvherre.pgsql>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: 
 <163681163886.16424.12786255003296837146.pgcf@coridan.postgresql.org>
Archived-At: 
 <https://www.postgresql.org/message-id/202111131523.jt7xzphdwc7b%40alvherre.pgsql>
Precedence: bulk

On 2021-Nov-13, Daniel Westermann wrote:

> /usr/bin/clang -Wno-ignored-attributes -fno-strict-aliasing -fwrapv -O2  -I../../../src/include  -D_GNU_SOURCE -I/usr/include/libxml2  -flto=thin -emit-llvm -c -o execMerge.bc execMerge.c
> execMerge.c:552:32: warning: if statement has empty body [-Wempty-body]
>                                         RELKIND_PARTITIONED_TABLE);
>                                                                   ^
> execMerge.c:552:32: note: put the semicolon on a separate line to silence this warning

Oh wow, this may be a pretty serious problem actually.  I think it
represents a gap in testing.  Thanks for reporting.

-- 
Álvaro Herrera           39°49'30"S 73°17'W  —  https://www.EnterpriseDB.com/