Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlutM-0008VS-Ct for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Nov 2021 15:24:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mlutL-0003bc-Az for pgsql-hackers@arkaria.postgresql.org; Sat, 13 Nov 2021 15:24:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlutL-0003bT-1r for pgsql-hackers@lists.postgresql.org; Sat, 13 Nov 2021 15:24:31 +0000 Received: from out2-smtp.messagingengine.com ([66.111.4.26]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mlutG-0006nr-EB for pgsql-hackers@lists.postgresql.org; Sat, 13 Nov 2021 15:24:27 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 7B0D15C0093; Sat, 13 Nov 2021 10:24:25 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Sat, 13 Nov 2021 10:24:25 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:subject:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; bh=Gfd8A4YSyDBFMUgeDKefSf2zOUmBLQeEijtK++4YzOE=; b=i2HnFsRr TlHnOBW1R0cMZ1LvkxSQP9Y6LkDRtwr9T+W1mHloDNTqRwW1nITSjUOvSYQKo/FO FNeeTsQ2zvWEX2ofw+tsTngoWjIA8D3mxqSQnzdvsA7lbofWT4YRRqX2rPxBIU4m oBeP4HuYEgu0U64iR7kMcC4SL/rjvZtVTEKUqVTTCoOU0Fr/s5p21e9+9l3GcnSa B8uaL3LTCpa/XFfWuJl5mZUrl2Fwun2tIapBYRCjY2X73GM1t20p27WPziyUvnBQ JWAiYLXyEdre4NqHrzqZyfrvVlBcStRw3hAggfL5Ll9aw7MZg+Kf9YhzCiVv3gQ4 c7AFxthQL78ylA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvuddrvdehgdejjecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkgggtugfgjgesthekredttddtjeenucfhrhhomheptehlvhgrrhho ucfjvghrrhgvrhgruceorghlvhhhvghrrhgvsegrlhhvhhdrnhhoqdhiphdrohhrgheqne cuggftrfgrthhtvghrnhepudejveejffejveduudetvdekieeuiedtvdeileefkeevjedu feeguedvjefhueelnecuffhomhgrihhnpegvnhhtvghrphhrihhsvggusgdrtghomhenuc evlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegrlhhvhhgv rhhrvgesrghlvhhhrdhnohdqihhprdhorhhg X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 13 Nov 2021 10:24:25 -0500 (EST) Received: by perhan.alvh.no-ip.org (Postfix, from userid 1000) id 3389A2A07D2; Sat, 13 Nov 2021 12:24:22 -0300 (-03) Date: Sat, 13 Nov 2021 12:24:22 -0300 From: Alvaro Herrera To: Zhihong Yu Cc: Pg Hackers Subject: Re: support for MERGE Message-ID: <202111131524.qwlxvpbovamf@alvherre.pgsql> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 2021-Nov-12, Zhihong Yu wrote: > This is continuation of review. > > + elog(WARNING, "hoping nothing needed here"); > > the above warning can be dropped. Hmm, yeah, the fact that this doesn't show up in the logs anywhere suggests that there is a gap in testing. -- Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/